mojo/services/public/interfaces/view_manager/view_manager.mojom - Issue 732223002: Rebuild aura::Window's property system on top of mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: The rest of the sky comments from the previous review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/public/interfaces/view_manager/view_manager.mojom

diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom

index 25e1f0686237c69e2af00be56c7b5b0e8e52e8c8..a79d4c6945ad889bd971da4afcce0e1df4324346 100644

--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom

+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom

@@ -191,7 +191,7 @@ interface ViewManagerClient {

// Invoked when a view property is changed. If this change is a removal,

// |new_data| is null.

- OnViewPropertyChanged(uint32 view, string name, array<uint8>? new_data);

+ OnViewSharedPropertyChanged(uint32 view, string name, array<uint8>? new_data);

// Invoked when an event is targeted at the specified view.

OnViewInputEvent(uint32 view, mojo.Event event) => ();