mojo/services/view_manager/test_change_tracker.h - Issue 732223002: Rebuild aura::Window's property system on top of mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/test_change_tracker.h

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: The rest of the sky comments from the previous review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/test_change_tracker.h

diff --git a/mojo/services/view_manager/test_change_tracker.h b/mojo/services/view_manager/test_change_tracker.h

index 261c106962d0f1e54f525cfa70eb3d261e392d04..368c2ad75f397245e1e7a391567f5584cc94889b 100644

--- a/mojo/services/view_manager/test_change_tracker.h

+++ b/mojo/services/view_manager/test_change_tracker.h

@@ -133,9 +133,9 @@ class TestChangeTracker {

void OnViewVisibilityChanged(Id view_id, bool visible);

void OnViewDrawnStateChanged(Id view_id, bool drawn);

void OnViewInputEvent(Id view_id, EventPtr event);

- void OnViewPropertyChanged(Id view_id,

- String name,

- Array<uint8_t> data);

+ void OnViewSharedPropertyChanged(Id view_id,

+ String name,

+ Array<uint8_t> data);

void DelegateEmbed(const String& url);

private: