mojo/services/view_manager/view_manager_service_impl.cc - Issue 732223002: Rebuild aura::Window's property system on top of mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/view_manager_service_impl.cc

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: The rest of the sky comments from the previous review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/view_manager_service_impl.cc

diff --git a/mojo/services/view_manager/view_manager_service_impl.cc b/mojo/services/view_manager/view_manager_service_impl.cc

index f7842ad5ca84bae576964a7510312945c367c566..e205feef77ed2098c32d1067b0224c1ca96c63e9 100644

--- a/mojo/services/view_manager/view_manager_service_impl.cc

+++ b/mojo/services/view_manager/view_manager_service_impl.cc

@@ -133,10 +133,8 @@ void ViewManagerServiceImpl::ProcessViewPropertyChanged(

if (new_data)

data = Array<uint8_t>::From(*new_data);

- client()->OnViewPropertyChanged(

- ViewIdToTransportId(view->id()),

- String(name),

- data.Pass());

+ client()->OnViewSharedPropertyChanged(ViewIdToTransportId(view->id()),

+ String(name), data.Pass());

}

void ViewManagerServiceImpl::ProcessViewHierarchyChanged(