mojo/services/view_manager/connection_manager.h - Issue 732223002: Rebuild aura::Window's property system on top of mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/connection_manager.h

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: The rest of the sky comments from the previous review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/connection_manager.h

diff --git a/mojo/services/view_manager/connection_manager.h b/mojo/services/view_manager/connection_manager.h

index 44e1b76fcd109f525676d40792700dbe48b3470e..9f0e9b1437db8341145c862a76c3c29813ce2570 100644

--- a/mojo/services/view_manager/connection_manager.h

+++ b/mojo/services/view_manager/connection_manager.h

@@ -172,9 +172,10 @@ class ConnectionManager : public ServerViewDelegate,

const ServerView* relative,

OrderDirection direction) override;

void OnWillChangeViewVisibility(const ServerView* view) override;

- void OnViewPropertyChanged(const ServerView* view,

- const std::string& name,

- const std::vector<uint8_t>* new_data) override;

+ void OnViewSharedPropertyChanged(

+ const ServerView* view,

+ const std::string& name,

+ const std::vector<uint8_t>* new_data) override;

// WindowManagerInternalClient:

void DispatchInputEventToView(Id transport_view_id,