mojo/services/view_manager/test_change_tracker.cc - Issue 732223002: Rebuild aura::Window's property system on top of mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/test_change_tracker.cc

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: The rest of the sky comments from the previous review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/test_change_tracker.cc

diff --git a/mojo/services/view_manager/test_change_tracker.cc b/mojo/services/view_manager/test_change_tracker.cc

index 0a3a0c13bd7538103c304905c618542f37c4274e..4241ecbae09ab41f1e10ce79d9856a5adbe8033f 100644

--- a/mojo/services/view_manager/test_change_tracker.cc

+++ b/mojo/services/view_manager/test_change_tracker.cc

@@ -249,9 +249,9 @@ void TestChangeTracker::OnViewInputEvent(Id view_id, EventPtr event) {

AddChange(change);

}

-void TestChangeTracker::OnViewPropertyChanged(Id view_id,

- String name,

- Array<uint8_t> data) {

+void TestChangeTracker::OnViewSharedPropertyChanged(Id view_id,

+ String name,

+ Array<uint8_t> data) {

Change change;

change.type = CHANGE_TYPE_PROPERTY_CHANGED;

change.view_id = view_id;