Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, johnme
Project:
blink
Visibility:
Public.

Description

The "push" event should inherit from ExtendableEvent. This makes it possible for developers to call waitUntil() on the event, in case its lifetime should be extended. Specification link (Push API): https://w3c.github.io/push-api/#the-push-event BUG=430888 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185374

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : s/object/constructor/ #

Patch Set 4 : rebase #

Patch Set 5 : one more nit #

Patch Set 6 : Remove PushEvent from global ctors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -16 lines) Patch
A LayoutTests/http/tests/push_messaging/pushevent-extendable-event.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/push_messaging/resources/pushevent-extendable-event.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushEvent.h View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/push_messaging/PushEvent.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/push_messaging/PushEvent.idl View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Peter Beverloo
+mvanouwerkerk for Push This depends on https://codereview.chromium.org/715013003/.
6 years, 1 month ago (2014-11-12 17:34:44 UTC) #2
Michael van Ouwerkerk
lgtm My goodness.
6 years, 1 month ago (2014-11-12 17:49:33 UTC) #3
Peter Beverloo
+mvanouwerkerk - Please re-check the test and Exposed= change. +michaeln - Service Workers changes. +mkwst ...
6 years, 1 month ago (2014-11-13 14:56:25 UTC) #5
Michael van Ouwerkerk
still lgtm
6 years, 1 month ago (2014-11-13 15:03:08 UTC) #6
Mike West
Source/web LGTM.
6 years, 1 month ago (2014-11-13 15:16:44 UTC) #7
falken
lgtm for service worker Service Worker patches link to the spec or spec discussion for ...
6 years, 1 month ago (2014-11-14 02:30:24 UTC) #9
Peter Beverloo
On 2014/11/14 02:30:24, falken wrote: > lgtm for service worker > > Service Worker patches ...
6 years, 1 month ago (2014-11-14 09:26:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716203003/80001
6 years, 1 month ago (2014-11-14 11:57:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/33634)
6 years, 1 month ago (2014-11-14 12:55:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716203003/100001
6 years, 1 month ago (2014-11-14 13:10:50 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 14:35:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 185374

Powered by Google App Engine
This is Rietveld 408576698