Source/modules/serviceworkers/WaitUntilObserver.cpp - Issue 716203003: The "push" event should inherit from ExtendableEvent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "modules/serviceworkers/WaitUntilObserver.h"	6 #include "modules/serviceworkers/WaitUntilObserver.h"

7	7

8 #include "bindings/core/v8/ScriptFunction.h"	8 #include "bindings/core/v8/ScriptFunction.h"

9 #include "bindings/core/v8/ScriptPromise.h"	9 #include "bindings/core/v8/ScriptPromise.h"

10 #include "bindings/core/v8/ScriptValue.h"	10 #include "bindings/core/v8/ScriptValue.h"

(...skipping 112 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
123 break;	123 break;

124 case Install:	124 case Install:

125 client->didHandleInstallEvent(m_eventID, result);	125 client->didHandleInstallEvent(m_eventID, result);

126 break;	126 break;

127 case NotificationClick:	127 case NotificationClick:

128 client->didHandleNotificationClickEvent(m_eventID, result);	128 client->didHandleNotificationClickEvent(m_eventID, result);

129 break;	129 break;

130 case NotificationError:	130 case NotificationError:

131 client->didHandleNotificationErrorEvent(m_eventID, result);	131 client->didHandleNotificationErrorEvent(m_eventID, result);

132 break;	132 break;

	133 case Push:

	134 client->didHandlePushEvent(m_eventID, result);

	135 break;

133 }	136 }

134 observeContext(0);	137 observeContext(0);

135 }	138 }

136	139

137 } // namespace blink	140 } // namespace blink

OLD	NEW

« no previous file with comments | « Source/modules/serviceworkers/WaitUntilObserver.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »