Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2393)

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.h

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushEvent.idl ('k') | Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/WaitUntilObserver.h
diff --git a/Source/modules/serviceworkers/WaitUntilObserver.h b/Source/modules/serviceworkers/WaitUntilObserver.h
index d64794f10e655771d0e9df655c4990599815311a..80b7b03a4a245876f7e20e970e8bb36641a24d05 100644
--- a/Source/modules/serviceworkers/WaitUntilObserver.h
+++ b/Source/modules/serviceworkers/WaitUntilObserver.h
@@ -23,7 +23,8 @@ public:
Activate,
Install,
NotificationClick,
- NotificationError
+ NotificationError,
+ Push
};
static WaitUntilObserver* create(ExecutionContext*, EventType, int eventID);
« no previous file with comments | « Source/modules/push_messaging/PushEvent.idl ('k') | Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698