Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: Source/modules/push_messaging/PushEvent.h

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushEvent.h
diff --git a/Source/modules/push_messaging/PushEvent.h b/Source/modules/push_messaging/PushEvent.h
index 506c57fe86ed3196ff7cfabe2a4466bf52a3fab9..aa49ee3ca8bfeb94076f0df5b5589457c2374e31 100644
--- a/Source/modules/push_messaging/PushEvent.h
+++ b/Source/modules/push_messaging/PushEvent.h
@@ -6,28 +6,29 @@
#define PushEvent_h
#include "modules/EventModules.h"
+#include "modules/serviceworkers/ExtendableEvent.h"
#include "platform/heap/Handle.h"
#include "wtf/text/AtomicString.h"
#include "wtf/text/WTFString.h"
namespace blink {
-struct PushEventInit : public EventInit {
+struct PushEventInit : public ExtendableEventInit {
PushEventInit();
String data;
};
-class PushEvent final : public Event {
+class PushEvent final : public ExtendableEvent {
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<PushEvent> create()
{
return adoptRefWillBeNoop(new PushEvent);
}
- static PassRefPtrWillBeRawPtr<PushEvent> create(const AtomicString& type, const String& data)
+ static PassRefPtrWillBeRawPtr<PushEvent> create(const AtomicString& type, const String& data, WaitUntilObserver* observer)
{
- return adoptRefWillBeNoop(new PushEvent(type, data));
+ return adoptRefWillBeNoop(new PushEvent(type, data, observer));
}
static PassRefPtrWillBeRawPtr<PushEvent> create(const AtomicString& type, const PushEventInit& initializer)
{
@@ -42,7 +43,7 @@ public:
private:
PushEvent();
- PushEvent(const AtomicString& type, const String& data);
+ PushEvent(const AtomicString& type, const String& data, WaitUntilObserver*);
PushEvent(const AtomicString& type, const PushEventInit&);
String m_data;
};
« no previous file with comments | « LayoutTests/webexposed/global-constructors-listing-expected.txt ('k') | Source/modules/push_messaging/PushEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698