Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: Source/modules/push_messaging/PushEvent.cpp

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushEvent.h ('k') | Source/modules/push_messaging/PushEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/push_messaging/PushEvent.cpp
diff --git a/Source/modules/push_messaging/PushEvent.cpp b/Source/modules/push_messaging/PushEvent.cpp
index 37fe117398816f68e4a3303196d76bd5f899fa7a..07ae8f27a1e14792e4b6f37c157ca11965059a8b 100644
--- a/Source/modules/push_messaging/PushEvent.cpp
+++ b/Source/modules/push_messaging/PushEvent.cpp
@@ -15,14 +15,14 @@ PushEvent::PushEvent()
{
}
-PushEvent::PushEvent(const AtomicString& type, const String& data)
- : Event(type, /*canBubble=*/false, /*cancelable=*/false)
+PushEvent::PushEvent(const AtomicString& type, const String& data, WaitUntilObserver* observer)
+ : ExtendableEvent(type, ExtendableEventInit(), observer)
, m_data(data)
{
}
PushEvent::PushEvent(const AtomicString& type, const PushEventInit& initializer)
- : Event(type, initializer)
+ : ExtendableEvent(type, initializer)
, m_data(initializer.data)
{
}
« no previous file with comments | « Source/modules/push_messaging/PushEvent.h ('k') | Source/modules/push_messaging/PushEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698