Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1859)

Unified Diff: Source/modules/push_messaging/PushEvent.idl

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushEvent.cpp ('k') | Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/push_messaging/PushEvent.idl
diff --git a/Source/modules/push_messaging/PushEvent.idl b/Source/modules/push_messaging/PushEvent.idl
index a6a03ff8d7895445e68bfcec475fc5db9afcf71d..e1c8a81fe2ec52c4bd194ba4206fadbef593444d 100644
--- a/Source/modules/push_messaging/PushEvent.idl
+++ b/Source/modules/push_messaging/PushEvent.idl
@@ -4,7 +4,8 @@
[
EventConstructor,
+ Exposed=ServiceWorker,
RuntimeEnabled=PushMessaging,
-] interface PushEvent : Event {
+] interface PushEvent : ExtendableEvent {
[InitializedByEventConstructor] readonly attribute DOMString data;
};
« no previous file with comments | « Source/modules/push_messaging/PushEvent.cpp ('k') | Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698