Source/modules/serviceworkers/WaitUntilObserver.cpp - Issue 716203003: The "push" event should inherit from ExtendableEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/WaitUntilObserver.cpp

diff --git a/Source/modules/serviceworkers/WaitUntilObserver.cpp b/Source/modules/serviceworkers/WaitUntilObserver.cpp

index 894f10d89b145b9ceb56941ba299b41c74f51451..f94d2ea0d6afe294d2c75dae5e867b0c4fa716ff 100644

--- a/Source/modules/serviceworkers/WaitUntilObserver.cpp

+++ b/Source/modules/serviceworkers/WaitUntilObserver.cpp

@@ -130,6 +130,9 @@ void WaitUntilObserver::decrementPendingActivity()

case NotificationError:

client->didHandleNotificationErrorEvent(m_eventID, result);

break;

+ case Push:

+ client->didHandlePushEvent(m_eventID, result);

+ break;

}

observeContext(0);

}