Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: Source/modules/serviceworkers/WaitUntilObserver.h

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WaitUntilObserver_h 5 #ifndef WaitUntilObserver_h
6 #define WaitUntilObserver_h 6 #define WaitUntilObserver_h
7 7
8 #include "core/dom/ContextLifecycleObserver.h" 8 #include "core/dom/ContextLifecycleObserver.h"
9 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h" 9 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"
10 #include "wtf/Forward.h" 10 #include "wtf/Forward.h"
11 #include "wtf/RefCounted.h" 11 #include "wtf/RefCounted.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 class ExecutionContext; 15 class ExecutionContext;
16 class ScriptState; 16 class ScriptState;
17 class ScriptValue; 17 class ScriptValue;
18 18
19 // Created for each ExtendableEvent instance. 19 // Created for each ExtendableEvent instance.
20 class WaitUntilObserver final : public GarbageCollectedFinalized<WaitUntilObserv er>, public ContextLifecycleObserver { 20 class WaitUntilObserver final : public GarbageCollectedFinalized<WaitUntilObserv er>, public ContextLifecycleObserver {
21 public: 21 public:
22 enum EventType { 22 enum EventType {
23 Activate, 23 Activate,
24 Install, 24 Install,
25 NotificationClick, 25 NotificationClick,
26 NotificationError 26 NotificationError,
27 Push
27 }; 28 };
28 29
29 static WaitUntilObserver* create(ExecutionContext*, EventType, int eventID); 30 static WaitUntilObserver* create(ExecutionContext*, EventType, int eventID);
30 31
31 // Must be called before and after dispatching the event. 32 // Must be called before and after dispatching the event.
32 void willDispatchEvent(); 33 void willDispatchEvent();
33 void didDispatchEvent(bool errorOccurred); 34 void didDispatchEvent(bool errorOccurred);
34 35
35 // Observes the promise and delays calling the continuation until 36 // Observes the promise and delays calling the continuation until
36 // the given promise is resolved or rejected. 37 // the given promise is resolved or rejected.
(...skipping 13 matching lines...) Expand all
50 51
51 EventType m_type; 52 EventType m_type;
52 int m_eventID; 53 int m_eventID;
53 int m_pendingActivity; 54 int m_pendingActivity;
54 bool m_hasError; 55 bool m_hasError;
55 }; 56 };
56 57
57 } // namespace blink 58 } // namespace blink
58 59
59 #endif // WaitUntilObserver_h 60 #endif // WaitUntilObserver_h
OLDNEW
« no previous file with comments | « Source/modules/push_messaging/PushEvent.idl ('k') | Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698