Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed)

Created:
6 years, 1 month ago by Yuki
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Project:
blink
Visibility:
Public.

Description

bindings: Explicitly passes a v8::Isolate to DOMDataStore. This CL makes DOMDataStore receive the v8::Isolate from the caller (creator of DOMDataStore), which should better know what isolate is to be used. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185027

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M Source/bindings/core/v8/DOMDataStore.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/DOMWrapperWorld.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/DOMWrapperWorld.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/PageScriptDebugServer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPreprocessor.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPreprocessor.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuki
Could you review this CL?
6 years, 1 month ago (2014-11-07 16:40:12 UTC) #2
haraken
LGTM https://codereview.chromium.org/707213002/diff/1/Source/bindings/core/v8/ScriptPreprocessor.h File Source/bindings/core/v8/ScriptPreprocessor.h (right): https://codereview.chromium.org/707213002/diff/1/Source/bindings/core/v8/ScriptPreprocessor.h#newcode44 Source/bindings/core/v8/ScriptPreprocessor.h:44: ScriptPreprocessor(const ScriptSourceCode&, LocalFrame*, v8::Isolate*); Put the isolate parameter ...
6 years, 1 month ago (2014-11-07 17:20:01 UTC) #3
Yuki
https://codereview.chromium.org/707213002/diff/1/Source/bindings/core/v8/ScriptPreprocessor.h File Source/bindings/core/v8/ScriptPreprocessor.h (right): https://codereview.chromium.org/707213002/diff/1/Source/bindings/core/v8/ScriptPreprocessor.h#newcode44 Source/bindings/core/v8/ScriptPreprocessor.h:44: ScriptPreprocessor(const ScriptSourceCode&, LocalFrame*, v8::Isolate*); On 2014/11/07 17:20:01, haraken wrote: ...
6 years, 1 month ago (2014-11-10 07:45:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707213002/20001
6 years, 1 month ago (2014-11-10 07:46:46 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 08:47:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185027

Powered by Google App Engine
This is Rietveld 408576698