Source/bindings/core/v8/ScriptPromisePropertyTest.cpp - Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

diff --git a/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp b/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

index 77bc5493743a8ffec093baf40bec692cac30bc50..6856d175cc492860c0875a1c275f7cce85337f67 100644

--- a/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

+++ b/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

@@ -125,7 +125,7 @@ public:

: m_page(DummyPageHolder::create(IntSize(1, 1)))

{

v8::HandleScope handleScope(isolate());

- m_otherScriptState = ScriptStateForTesting::create(v8::Context::New(isolate()), DOMWrapperWorld::create(1));

+ m_otherScriptState = ScriptStateForTesting::create(v8::Context::New(isolate()), DOMWrapperWorld::create(isolate(), 1));

}

virtual ~ScriptPromisePropertyTestBase()