Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: Source/bindings/core/v8/DOMWrapperWorld.h

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/DOMDataStore.h ('k') | Source/bindings/core/v8/DOMWrapperWorld.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/DOMWrapperWorld.h
diff --git a/Source/bindings/core/v8/DOMWrapperWorld.h b/Source/bindings/core/v8/DOMWrapperWorld.h
index f5785a3807998060d98f629e5fb19465a704ac95..7f1f8a6e1bff3fc7f7e120a2f7106e18f389bd77 100644
--- a/Source/bindings/core/v8/DOMWrapperWorld.h
+++ b/Source/bindings/core/v8/DOMWrapperWorld.h
@@ -57,11 +57,11 @@ enum WorldIdConstants {
// This class represent a collection of DOM wrappers for a specific world.
class DOMWrapperWorld : public RefCounted<DOMWrapperWorld> {
public:
- static PassRefPtr<DOMWrapperWorld> create(int worldId = -1, int extensionGroup = -1);
+ static PassRefPtr<DOMWrapperWorld> create(v8::Isolate*, int worldId = -1, int extensionGroup = -1);
static const int mainWorldExtensionGroup = 0;
static const int privateScriptIsolatedWorldExtensionGroup = 1;
- static PassRefPtr<DOMWrapperWorld> ensureIsolatedWorld(int worldId, int extensionGroup);
+ static PassRefPtr<DOMWrapperWorld> ensureIsolatedWorld(v8::Isolate*, int worldId, int extensionGroup);
~DOMWrapperWorld();
void dispose();
@@ -173,7 +173,7 @@ public:
}
private:
- DOMWrapperWorld(int worldId, int extensionGroup);
+ DOMWrapperWorld(v8::Isolate*, int worldId, int extensionGroup);
static void weakCallbackForDOMObjectHolder(const v8::WeakCallbackData<v8::Value, DOMObjectHolderBase>&);
void registerDOMObjectHolderInternal(PassOwnPtr<DOMObjectHolderBase>);
« no previous file with comments | « Source/bindings/core/v8/DOMDataStore.h ('k') | Source/bindings/core/v8/DOMWrapperWorld.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698