Source/bindings/core/v8/V8GCController.cpp - Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8GCController.cpp

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8GCController.cpp

diff --git a/Source/bindings/core/v8/V8GCController.cpp b/Source/bindings/core/v8/V8GCController.cpp

index dbc27dbfb0434b51e44ff86f74f8af0f212f494f..5991bafb257c717155599d4ae2c65b4df62854e8 100644

--- a/Source/bindings/core/v8/V8GCController.cpp

+++ b/Source/bindings/core/v8/V8GCController.cpp

@@ -457,7 +457,7 @@ void V8GCController::majorGCEpilogue(v8::Isolate* isolate)

void V8GCController::collectGarbage(v8::Isolate* isolate)

{

v8::HandleScope handleScope(isolate);

- RefPtr<ScriptState> scriptState = ScriptState::create(v8::Context::New(isolate), DOMWrapperWorld::create());

+ RefPtr<ScriptState> scriptState = ScriptState::create(v8::Context::New(isolate), DOMWrapperWorld::create(isolate));

ScriptState::Scope scope(scriptState.get());

V8ScriptRunner::compileAndRunInternalScript(v8String(isolate, "if (gc) gc();"), isolate);

scriptState->disposePerContextData();