Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Side by Side Diff: Source/bindings/core/v8/ScriptPreprocessor.h

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 18 matching lines...) Expand all
29 */ 29 */
30 #ifndef ScriptPreprocessor_h 30 #ifndef ScriptPreprocessor_h
31 #define ScriptPreprocessor_h 31 #define ScriptPreprocessor_h
32 32
33 #include "bindings/core/v8/V8Binding.h" 33 #include "bindings/core/v8/V8Binding.h"
34 #include <v8.h> 34 #include <v8.h>
35 35
36 namespace blink { 36 namespace blink {
37 37
38 class ScriptSourceCode; 38 class ScriptSourceCode;
39 class ScriptState;
39 40
40 class ScriptPreprocessor { 41 class ScriptPreprocessor {
41 WTF_MAKE_NONCOPYABLE(ScriptPreprocessor); 42 WTF_MAKE_NONCOPYABLE(ScriptPreprocessor);
42 public: 43 public:
43 ScriptPreprocessor(const ScriptSourceCode&, LocalFrame*); 44 ScriptPreprocessor(v8::Isolate*, const ScriptSourceCode&, LocalFrame*);
44 String preprocessSourceCode(const String& sourceCode, const String& sourceNa me); 45 String preprocessSourceCode(const String& sourceCode, const String& sourceNa me);
45 String preprocessSourceCode(const String& sourceCode, const String& sourceNa me, const String& functionName); 46 String preprocessSourceCode(const String& sourceCode, const String& sourceNa me, const String& functionName);
46 bool isPreprocessing() { return m_isPreprocessing; } 47 bool isPreprocessing() { return m_isPreprocessing; }
47 bool isValid() { return !m_preprocessorFunction.isEmpty(); } 48 bool isValid() { return !m_preprocessorFunction.isEmpty(); }
48 49
49 private: 50 private:
50 String preprocessSourceCode(const String& sourceCode, const String& sourceNa me, v8::Handle<v8::Value> functionName); 51 String preprocessSourceCode(const String& sourceCode, const String& sourceNa me, v8::Handle<v8::Value> functionName);
51 RefPtr<ScriptState> m_scriptState; 52 RefPtr<ScriptState> m_scriptState;
52 ScopedPersistent<v8::Function> m_preprocessorFunction; 53 ScopedPersistent<v8::Function> m_preprocessorFunction;
53 bool m_isPreprocessing; 54 bool m_isPreprocessing;
54 }; 55 };
55 56
56 } // namespace blink 57 } // namespace blink
57 58
58 #endif // ScriptPreprocessor_h 59 #endif // ScriptPreprocessor_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptController.cpp ('k') | Source/bindings/core/v8/ScriptPreprocessor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698