Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: Source/bindings/core/v8/ScriptPreprocessor.cpp

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPreprocessor.h ('k') | Source/bindings/core/v8/ScriptPromisePropertyTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPreprocessor.cpp
diff --git a/Source/bindings/core/v8/ScriptPreprocessor.cpp b/Source/bindings/core/v8/ScriptPreprocessor.cpp
index 4d1152068369c6b9724fd2062d8243dbd495fa8b..0df0d7aeb0a95fa2949bb9064fe01446f3e248f3 100644
--- a/Source/bindings/core/v8/ScriptPreprocessor.cpp
+++ b/Source/bindings/core/v8/ScriptPreprocessor.cpp
@@ -44,10 +44,10 @@
namespace blink {
-ScriptPreprocessor::ScriptPreprocessor(const ScriptSourceCode& preprocessorSourceCode, LocalFrame* frame)
+ScriptPreprocessor::ScriptPreprocessor(v8::Isolate* isolate, const ScriptSourceCode& preprocessorSourceCode, LocalFrame* frame)
: m_isPreprocessing(false)
{
- RefPtr<DOMWrapperWorld> world = DOMWrapperWorld::ensureIsolatedWorld(ScriptPreprocessorIsolatedWorldId, DOMWrapperWorld::mainWorldExtensionGroup);
+ RefPtr<DOMWrapperWorld> world = DOMWrapperWorld::ensureIsolatedWorld(isolate, ScriptPreprocessorIsolatedWorldId, DOMWrapperWorld::mainWorldExtensionGroup);
m_scriptState = ScriptState::from(toV8Context(frame, *world));
v8::HandleScope handleScope(m_scriptState->isolate());
« no previous file with comments | « Source/bindings/core/v8/ScriptPreprocessor.h ('k') | Source/bindings/core/v8/ScriptPromisePropertyTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698