Source/bindings/core/v8/ScriptPreprocessor.h - Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPreprocessor.h

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptPreprocessor.h

diff --git a/Source/bindings/core/v8/ScriptPreprocessor.h b/Source/bindings/core/v8/ScriptPreprocessor.h

index 7dc15b9420d0a5fe223112f03b087e7ce1032e4d..8bc7de0acb531ad5d3fe0389b2c754845d53eec7 100644

--- a/Source/bindings/core/v8/ScriptPreprocessor.h

+++ b/Source/bindings/core/v8/ScriptPreprocessor.h

@@ -36,11 +36,12 @@

namespace blink {

class ScriptSourceCode;

+class ScriptState;

class ScriptPreprocessor {

WTF_MAKE_NONCOPYABLE(ScriptPreprocessor);

public:

- ScriptPreprocessor(const ScriptSourceCode&, LocalFrame*);

+ ScriptPreprocessor(v8::Isolate*, const ScriptSourceCode&, LocalFrame*);

String preprocessSourceCode(const String& sourceCode, const String& sourceName);

String preprocessSourceCode(const String& sourceCode, const String& sourceName, const String& functionName);

bool isPreprocessing() { return m_isPreprocessing; }