Source/bindings/core/v8/PageScriptDebugServer.cpp - Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/PageScriptDebugServer.cpp

Issue 707213002: bindings: Explicitly passes a v8::Isolate to DOMDataStore. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/PageScriptDebugServer.cpp

diff --git a/Source/bindings/core/v8/PageScriptDebugServer.cpp b/Source/bindings/core/v8/PageScriptDebugServer.cpp

index 264bb85d470417f11f9f29b112049030806d90b3..3b7e1d7e83826838a39595191e66d6a176c4f1c3 100644

--- a/Source/bindings/core/v8/PageScriptDebugServer.cpp

+++ b/Source/bindings/core/v8/PageScriptDebugServer.cpp

@@ -278,7 +278,7 @@ bool PageScriptDebugServer::canPreprocess(LocalFrame* frame)

// Web page to ensure that the debugger's console initialization code has completed.

if (!m_scriptPreprocessor) {

TemporaryChange<bool> isPreprocessing(isCreatingPreprocessor, true);

- m_scriptPreprocessor = adoptPtr(new ScriptPreprocessor(*m_preprocessorSourceCode.get(), frame));

+ m_scriptPreprocessor = adoptPtr(new ScriptPreprocessor(m_isolate, *m_preprocessorSourceCode.get(), frame));

}

if (m_scriptPreprocessor->isValid())