Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs. (I first tried to move cocoa/android impl, but it turns out to be more difficult than I originally thought so I left them as they are) Introduced JavaScriptDialogManagerClient for embedder to implement extensions related behaviors. BUG=410499 TBR=blundell@chromium.org Committed: https://crrev.com/758abebc6360e6c4bad50acd851a0c41c85695ac Cr-Commit-Position: refs/heads/master@{#303004}

Patch Set 1 : #

Total comments: 18

Patch Set 2 : #

Total comments: 14

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : similarity=30 #

Total comments: 17

Patch Set 6 : #

Patch Set 7 : #

Total comments: 87

Patch Set 8 #

Total comments: 6

Patch Set 9 : #

Total comments: 4

Patch Set 10 : #

Total comments: 5

Patch Set 11 : #

Total comments: 2

Patch Set 12 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+797 lines, -703 lines) Patch
M chrome/browser/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 2 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.cc View 1 2 3 4 5 6 7 8 9 4 chunks +32 lines, -14 lines 0 comments Download
A chrome/browser/ui/app_modal_dialogs/chrome_javascript_native_dialog_factory.h View 1 2 5 1 chunk +11 lines, -0 lines 0 comments Download
D chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc View 1 chunk +0 lines, -322 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 1 2 3 4 5 6 7 8 9 2 chunks +25 lines, -8 lines 1 comment Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc View 1 2 3 4 5 6 7 8 1 chunk +47 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/javascript_app_modal_dialog_views.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/views/javascript_app_modal_dialog_views.cc View 1 chunk +0 lines, -188 lines 0 comments Download
A chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +10 lines, -5 lines 0 comments Download
M components/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/app_modal_dialogs.gypi View 1 2 3 4 5 6 7 3 chunks +16 lines, -3 lines 0 comments Download
M components/app_modal_dialogs/BUILD.gn View 1 2 1 chunk +15 lines, -1 line 0 comments Download
M components/app_modal_dialogs/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/app_modal_dialogs/javascript_app_modal_dialog.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
A components/app_modal_dialogs/javascript_dialog_extensions_client.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +38 lines, -0 lines 0 comments Download
A components/app_modal_dialogs/javascript_dialog_manager.h View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
A components/app_modal_dialogs/javascript_dialog_manager.cc View 1 2 3 4 5 6 7 1 chunk +25 lines, -0 lines 0 comments Download
A components/app_modal_dialogs/javascript_dialog_manager_impl.h View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A components/app_modal_dialogs/javascript_dialog_manager_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +233 lines, -0 lines 0 comments Download
A components/app_modal_dialogs/javascript_native_dialog_factory.h View 1 2 3 4 5 6 7 1 chunk +24 lines, -0 lines 0 comments Download
M components/app_modal_dialogs/native_app_modal_dialog.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
A components/app_modal_dialogs/views/DEPS View 5 1 chunk +5 lines, -0 lines 0 comments Download
A + components/app_modal_dialogs/views/javascript_app_modal_dialog_views.h View 4 chunks +3 lines, -13 lines 0 comments Download
A + components/app_modal_dialogs/views/javascript_app_modal_dialog_views.cc View 1 2 5 chunks +1 line, -36 lines 0 comments Download
M extensions/components/extensions_components.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + extensions/components/javascript_dialog_extensions_client.gypi View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
A + extensions/components/javascript_dialog_extensions_client/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -7 lines 0 comments Download
A extensions/components/javascript_dialog_extensions_client/DEPS View 1 2 5 1 chunk +6 lines, -0 lines 0 comments Download
A extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.h View 1 2 5 1 chunk +11 lines, -0 lines 0 comments Download
A extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 63 (26 generated)
oshima
6 years, 1 month ago (2014-10-29 00:21:29 UTC) #13
oshima
On 2014/10/29 00:21:29, oshima wrote: msw -> chrome/ avi -> owner of app_modal_dialogs
6 years, 1 month ago (2014-10-29 00:22:29 UTC) #14
Avi (use Gerrit)
https://codereview.chromium.org/666533007/diff/200001/chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h File chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h (right): https://codereview.chromium.org/666533007/diff/200001/chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h#newcode35 chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h:35: // specific files. Are we eventually going to move ...
6 years, 1 month ago (2014-10-29 17:40:57 UTC) #15
msw
I've only just begun reviewing, but have a few comments. Overall, I can't dedicate time ...
6 years, 1 month ago (2014-10-30 00:20:32 UTC) #16
pkotwicz
https://codereview.chromium.org/666533007/diff/220001/chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc File chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc (right): https://codereview.chromium.org/666533007/diff/220001/chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc#newcode7 chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc:7: #include "chrome/browser/ui/views/javascript_app_modal_event_blocker_x11.h" The right place for this logic is ...
6 years, 1 month ago (2014-10-30 02:46:15 UTC) #18
oshima
I separate JavaScriptDialogManagerClient into two - JavaScriptDialogExtensionsClient to access //extensions functions. - JavaScriptNativeDialogFactory to create ...
6 years, 1 month ago (2014-10-31 15:54:45 UTC) #19
oshima
https://codereview.chromium.org/666533007/diff/280001/components/app_modal_dialogs/javascript_dialog_manager.h File components/app_modal_dialogs/javascript_dialog_manager.h (right): https://codereview.chromium.org/666533007/diff/280001/components/app_modal_dialogs/javascript_dialog_manager.h#newcode1 components/app_modal_dialogs/javascript_dialog_manager.h:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
6 years, 1 month ago (2014-10-31 16:33:10 UTC) #20
pkotwicz
https://codereview.chromium.org/666533007/diff/280001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/666533007/diff/280001/chrome/browser/chrome_browser_main.cc#newcode1070 chrome/browser/chrome_browser_main.cc:1070: InstallJavaScriptDialogExtensionsClient(); We are leaking the pointer here. Does it ...
6 years, 1 month ago (2014-10-31 17:02:44 UTC) #21
pkotwicz
https://codereview.chromium.org/666533007/diff/280001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/666533007/diff/280001/chrome/browser/chrome_browser_main.cc#newcode1070 chrome/browser/chrome_browser_main.cc:1070: InstallJavaScriptDialogExtensionsClient(); Never mind, I stand corrected
6 years, 1 month ago (2014-10-31 17:07:41 UTC) #22
oshima
ping?
6 years, 1 month ago (2014-11-03 21:51:08 UTC) #23
Avi (use Gerrit)
I'm reasonably OK with this. It's rather unfortunate that we can't move all the implementations ...
6 years, 1 month ago (2014-11-04 20:46:41 UTC) #24
oshima
PTAL https://codereview.chromium.org/666533007/diff/280001/chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc File chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc (right): https://codereview.chromium.org/666533007/diff/280001/chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc#newcode14 chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc:14: class ChromeJavaScritpNativeDialogAndroidFactory On 2014/11/04 20:46:41, Avi wrote: > ...
6 years, 1 month ago (2014-11-04 23:12:18 UTC) #26
Avi (use Gerrit)
LGTM
6 years, 1 month ago (2014-11-04 23:55:23 UTC) #27
msw
https://codereview.chromium.org/666533007/diff/280001/components/app_modal_dialogs/javascript_dialog_manager.h File components/app_modal_dialogs/javascript_dialog_manager.h (right): https://codereview.chromium.org/666533007/diff/280001/components/app_modal_dialogs/javascript_dialog_manager.h#newcode1 components/app_modal_dialogs/javascript_dialog_manager.h:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
6 years, 1 month ago (2014-11-05 03:53:56 UTC) #28
oshima
avi@, can you answer two questions below? https://codereview.chromium.org/666533007/diff/280001/components/constrained_window/constrained_window_views.h File components/constrained_window/constrained_window_views.h (right): https://codereview.chromium.org/666533007/diff/280001/components/constrained_window/constrained_window_views.h#newcode54 components/constrained_window/constrained_window_views.h:54: views::Widget* CreateWindowModalDialogViews(views::DialogDelegate* ...
6 years, 1 month ago (2014-11-05 21:42:19 UTC) #29
Avi (use Gerrit)
https://codereview.chromium.org/666533007/diff/280001/components/constrained_window/constrained_window_views.h File components/constrained_window/constrained_window_views.h (right): https://codereview.chromium.org/666533007/diff/280001/components/constrained_window/constrained_window_views.h#newcode54 components/constrained_window/constrained_window_views.h:54: views::Widget* CreateWindowModalDialogViews(views::DialogDelegate* dialog, On 2014/11/05 21:42:17, oshima wrote: > ...
6 years, 1 month ago (2014-11-05 21:50:40 UTC) #30
msw
lgtm iff you remove the bad file: components/app_modal_dialogs/cocoa/DEPS. Please also remove the CL description comment ...
6 years, 1 month ago (2014-11-05 22:59:06 UTC) #31
oshima
msw@ PTAL avi@, what is your opinion about msw@'s comment for components/app_modal_dialogs/javascript_dialog_manager.h ? https://codereview.chromium.org/666533007/diff/340001/chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc File ...
6 years, 1 month ago (2014-11-05 23:22:49 UTC) #34
msw
lgtm with nits. https://codereview.chromium.org/666533007/diff/340001/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc File chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc (right): https://codereview.chromium.org/666533007/diff/340001/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc#newcode1 chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc:1: // Copyright 2014 The Chromium Authors. ...
6 years, 1 month ago (2014-11-05 23:34:37 UTC) #35
oshima
i'll address javascript_dialog_manager.{h|cc} in a separate CL if necessary. https://codereview.chromium.org/666533007/diff/420001/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc File chrome/browser/ui/android/javascript_app_modal_dialog_android.cc (right): https://codereview.chromium.org/666533007/diff/420001/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc#newcode9 chrome/browser/ui/android/javascript_app_modal_dialog_android.cc:9: ...
6 years, 1 month ago (2014-11-06 00:04:32 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666533007/440001
6 years, 1 month ago (2014-11-06 00:05:17 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22441)
6 years, 1 month ago (2014-11-06 00:15:23 UTC) #40
oshima
yoz, scheib, can one of you review extensions/components ?
6 years, 1 month ago (2014-11-06 00:48:46 UTC) #43
Yoyo Zhou
LGTM with nits https://chromiumcodereview.appspot.com/666533007/diff/440001/components/app_modal_dialogs/javascript_dialog_extensions_client.h File components/app_modal_dialogs/javascript_dialog_extensions_client.h (right): https://chromiumcodereview.appspot.com/666533007/diff/440001/components/app_modal_dialogs/javascript_dialog_extensions_client.h#newcode25 components/app_modal_dialogs/javascript_dialog_extensions_client.h:25: virtual void IncrementLazyKeepaliveCount( I think I'd ...
6 years, 1 month ago (2014-11-06 01:05:03 UTC) #44
oshima
thestig@, can you approve changes in chrome/browser/chrome_browser_main.cc chrome/browser/ui/android/javascript_app_modal_dialog_android.cc ? tbrin'g blundel for components/BUILD.gn https://codereview.chromium.org/666533007/diff/440001/components/app_modal_dialogs/javascript_dialog_extensions_client.h File ...
6 years, 1 month ago (2014-11-06 01:47:44 UTC) #47
Lei Zhang
On 2014/11/06 01:47:44, oshima wrote: > thestig@, can you approve changes in > > chrome/browser/chrome_browser_main.cc ...
6 years, 1 month ago (2014-11-06 03:47:38 UTC) #48
Avi (use Gerrit)
https://codereview.chromium.org/666533007/diff/340001/components/app_modal_dialogs/javascript_dialog_manager.cc File components/app_modal_dialogs/javascript_dialog_manager.cc (right): https://codereview.chromium.org/666533007/diff/340001/components/app_modal_dialogs/javascript_dialog_manager.cc#newcode5 components/app_modal_dialogs/javascript_dialog_manager.cc:5: #include "components/app_modal_dialogs/javascript_dialog_manager.h" Hmmm. Yes, I did miss this. Impl ...
6 years, 1 month ago (2014-11-06 05:26:57 UTC) #49
oshima
https://codereview.chromium.org/666533007/diff/340001/components/app_modal_dialogs/javascript_dialog_manager.cc File components/app_modal_dialogs/javascript_dialog_manager.cc (right): https://codereview.chromium.org/666533007/diff/340001/components/app_modal_dialogs/javascript_dialog_manager.cc#newcode5 components/app_modal_dialogs/javascript_dialog_manager.cc:5: #include "components/app_modal_dialogs/javascript_dialog_manager.h" On 2014/11/06 05:26:57, Avi wrote: > Hmmm. ...
6 years, 1 month ago (2014-11-06 06:32:07 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666533007/480001
6 years, 1 month ago (2014-11-06 06:32:51 UTC) #52
blundell
I'm a little confused by this CL. It doesn't seem to have anything I need ...
6 years, 1 month ago (2014-11-06 06:55:36 UTC) #54
blundell
On 2014/11/06 06:55:36, blundell wrote: > I'm a little confused by this CL. It doesn't ...
6 years, 1 month ago (2014-11-06 06:56:55 UTC) #55
blundell
//components/BUILD.gn lgtm
6 years, 1 month ago (2014-11-06 06:58:21 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666533007/480001
6 years, 1 month ago (2014-11-06 10:54:43 UTC) #58
commit-bot: I haz the power
Committed patchset #12 (id:480001)
6 years, 1 month ago (2014-11-06 10:56:00 UTC) #59
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/758abebc6360e6c4bad50acd851a0c41c85695ac Cr-Commit-Position: refs/heads/master@{#303004}
6 years, 1 month ago (2014-11-06 10:56:46 UTC) #60
Jiang Jiang
https://codereview.chromium.org/666533007/diff/480001/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm File chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm (right): https://codereview.chromium.org/666533007/diff/480001/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm#newcode445 chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm:445: ChromeJavaScritpNativeDialogCocoaFactory() {} Typo.
6 years, 1 month ago (2014-11-18 13:03:05 UTC) #62
oshima
6 years, 1 month ago (2014-11-18 14:58:20 UTC) #63
Message was sent while issue was closed.
On 2014/11/18 13:03:05, Jiang Jiang wrote:
>
https://codereview.chromium.org/666533007/diff/480001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm (right):
> 
>
https://codereview.chromium.org/666533007/diff/480001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm:445:
> ChromeJavaScritpNativeDialogCocoaFactory() {}
> Typo.

Thank you for the catch. Look like I skipped mm when converting them.

Powered by Google App Engine
This is Rietveld 408576698