Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

components/app_modal_dialogs/javascript_dialog_manager_client.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_DIALOG_MANAGER_CLIENT_H_
+#define COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_DIALOG_MANAGER_CLIENT_H_
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+#include "ui/gfx/native_widget_types.h"
+
+class GURL;
+class NativeAppModalDialog;
+class JavaScriptAppModalDialog;

[Avi (use Gerrit), 2014/10/29 17:40:57]

Alphabetize

[oshima, 2014/10/31 15:54:45]

Done.

+
+namespace content {
+class WebContents;
+}
+
+class JavaScriptDialogManagerClient {
+ public:
+  virtual ~JavaScriptDialogManagerClient() {}
+
+  // Creates an app modal dialog for a JavaScript prompt;
+  virtual NativeAppModalDialog* CreateNativeJavaScriptPrompt(
+      JavaScriptAppModalDialog* dialog,
+      gfx::NativeWindow parent_window) = 0;

[Avi (use Gerrit), 2014/10/29 17:40:57]

I'm having trouble getting my head around this. Embedders implement this client
interface for the component to ask it to do things. Why does the client
interface have "CreateNativeJavaScriptPrompt"? Isn't that what the client is
asking the component to do?

[oshima, 2014/10/31 15:54:45]

app_modal_dialog provides the basic framework for web contents to create dialog,
and
embedder provides a native impl of dialog window using this interface.

+
+  // Called when the extension associated with |web_contents| opened
+  // a dialog. The embedder should increment its keep alive count so
+  // that its lazy background page can stay alive.
+  virtual void IncrementLazyKeepaliveCount(
+      content::WebContents* web_contents) = 0;
+
+  // Called when a dialog created by the extension associated with
+  // |web_contents| is closed. The embedder should decrement
+  // its keep alive count so that the extension can shutdown
+  // its lazy background page.
+  virtual void DecrementLazyKeepaliveCount(
+      content::WebContents* web_contents) = 0;
+
+  // Sets the name of the extensions associated with the |web_contents|
+  // in the |name_out|, and returns true. If there is no extension associated
+  // with the |web_contents|, returns false.
+  virtual bool GetExtensionName(content::WebContents* web_contents,
+                                const GURL& origin_url,
+                                std::string* name_out) = 0;

[Avi (use Gerrit), 2014/10/29 17:40:57]

I'm kinda weirded out by these three calls. Does this component have a
dependency on extensions? If not, then can we name these something more generic?

[oshima, 2014/10/31 15:54:45]

app_modal_dialog assume existence of extensions (except for android).

+};
+
+void SetJavaScriptDialogManagerClient(
+    scoped_ptr<JavaScriptDialogManagerClient> client);
+
+JavaScriptDialogManagerClient* GetJavaScriptDialogManagerClient();
+
+#endif  // COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_DIALOG_MANAGER_CLIENT_H_