Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

chrome/browser/chrome_browser_main_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_android.h"
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/path_service.h"
 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
 #include "chrome/browser/google/google_search_counter_android.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/crash/app/breakpad_linux.h"
 #include "components/crash/browser/crash_dump_manager_android.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "content/public/browser/android/compositor.h"
 #include "content/public/common/main_function_params.h"
 #include "net/android/network_change_notifier_factory_android.h"
 #include "net/base/network_change_notifier.h"
 #include "ui/base/ui_base_paths.h"
 
 ChromeBrowserMainPartsAndroid::ChromeBrowserMainPartsAndroid(
     const content::MainFunctionParams& parameters)
     : ChromeBrowserMainParts(parameters) {
 }
 
 ChromeBrowserMainPartsAndroid::~ChromeBrowserMainPartsAndroid() {
+  SetJavaScriptDialogManagerClient(nullptr);
 }
 
 void ChromeBrowserMainPartsAndroid::PreProfileInit() {
   TRACE_EVENT0("startup", "ChromeBrowserMainPartsAndroid::PreProfileInit")
 #if defined(GOOGLE_CHROME_BUILD)
   // TODO(jcivelli): we should not initialize the crash-reporter when it was not
   // enabled. Right now if it is disabled we still generate the minidumps but we
   // do not upload them.
   bool breakpad_enabled = true;
 #else
   bool breakpad_enabled = false;
 #endif
+  SetJavaScriptDialogManagerClient(

[msw, 2014/10/30 00:20:31]

Does this need to happen so early? Can someone more relevant review this bit?

+      make_scoped_ptr(new ChromeJavaScriptDialogManagerClient));

[msw, 2014/10/30 00:20:31]

Why do android, mac, and views all do this separately, is there no way for all
three to share the same client creation and destruction code?

[oshima, 2014/10/31 15:54:45]

Moved to chrome_browser_main.cc. Let me know if you have any recomendation and
I'm happy to move.

 
   // Allow Breakpad to be enabled in Chromium builds for testing purposes.
   if (!breakpad_enabled)
     breakpad_enabled = CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableCrashReporterForTesting);
 
   if (breakpad_enabled) {
     base::FilePath crash_dump_dir;
     PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dump_dir);
     crash_dump_manager_.reset(new breakpad::CrashDumpManager(crash_dump_dir));
@@ skipping 35 matching lines @@
       "ChromeBrowserMainPartsAndroid::PreEarlyInitialization:StartUiMsgLoop");
     base::MessageLoopForUI::current()->Start();
   }
 
   ChromeBrowserMainParts::PreEarlyInitialization();
 }
 
 void ChromeBrowserMainPartsAndroid::ShowMissingLocaleMessageBox() {
   NOTREACHED();
 }