chrome/browser/ui/views/chrome_javascript_native_dialog_factory.h - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/chrome_javascript_native_dialog_factory.h

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/chrome_javascript_native_dialog_factory_cocoa.mm ('K') | « chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc ('k') | chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc » ('j') | chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	msw 2014/11/05 03:53:55 Is this file actually needed? I don't think you ev Is this file actually needed? I don't think you even added it to a gyp target. Isn't chrome/browser/ui/app_modal_dialogs/chrome_javascript_native_dialog_factory.h sufficient? oshima 2014/11/05 21:42:18 This was supposed to be removed. thanks you for th Show quoted text On 2014/11/05 03:53:55, msw wrote: > Is this file actually needed? I don't think you even added it to a gyp target. > Isn't > chrome/browser/ui/app_modal_dialogs/chrome_javascript_native_dialog_factory.h > sufficient? This was supposed to be removed. thanks you for the catch.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_APP_MODAL_DIALOGS_CHROME_JAVASCRIPT_NATIVE_DIALOG_FACT ORY_H_
	msw 2014/11/05 03:53:55 Fix this guard... Fix this guard...
	6 #define CHROME_BROWSER_UI_APP_MODAL_DIALOGS_CHROME_JAVASCRIPT_NATIVE_DIALOG_FACT ORY_H_

	7

	8 void InstallChromeJavaScriptNativeDialogFactory();

	9

	10 #endif // CHROME_BROWSER_UI_APP_MODAL_DIALOGS_CHROME_JAVASCRIPT_NATIVE_DIALOG_F ACTORY_H_

	11

OLD	NEW