components/app_modal_dialogs/cocoa/DEPS - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/app_modal_dialogs/cocoa/DEPS

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc ('K') | « components/app_modal_dialogs/DEPS ('k') | components/app_modal_dialogs/javascript_app_modal_dialog.cc » ('j') | components/constrained_window/constrained_window_views.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [
	msw 2014/11/05 22:59:06 Please remove this file! As per the earlier commen Please remove this file! As per the earlier comment: https://codereview.chromium.org/666533007/diff/340001/components/app_modal_di... oshima 2014/11/05 23:22:49 Done. Show quoted text On 2014/11/05 22:59:06, msw wrote: > Please remove this file! As per the earlier comment: > > https://codereview.chromium.org/666533007/diff/340001/components/app_modal_di... Done.
2 "-chromeos",	2 "+ui/strings",

3 ]	3 ]

OLD	NEW