extensions/components/javascript_dialog_extensions_client/BUILD.gn - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/components/javascript_dialog_extensions_client/BUILD.gn

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« extensions/components/extensions_components.gyp ('K') | « extensions/components/javascript_dialog_extensions_client.gypi ('k') | extensions/components/javascript_dialog_extensions_client/DEPS » ('j') | extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("native_app_window") {	5 static_library("javascript_dialog_extensions_client") {

6 sources = [	6 sources = [

7 "native_app_window_views.cc",	7 "javascript_dialog_extension_client_impl.cc",

8 "native_app_window_views.h",	8 "javascript_dialog_extension_client_impl.h",

9 ]	9 ]

10	10

11 deps = [	11 deps = [
	msw 2014/11/05 03:53:56 Does this need a dependency for javascript_dialog_ Does this need a dependency for javascript_dialog_extension_client_impl.cc's "content/public/browser/web_contents.h" include? oshima 2014/11/05 21:42:19 Binary dependency is pulled from extensions. I can Show quoted text On 2014/11/05 03:53:56, msw wrote: > Does this need a dependency for javascript_dialog_extension_client_impl.cc's > "content/public/browser/web_contents.h" include? Binary dependency is pulled from extensions. I can add if you want as it's harmless. let me know. msw 2014/11/05 22:59:06 Sure, it doesn't hurt to explicitly list dependenc Show quoted text On 2014/11/05 21:42:19, oshima wrote: > On 2014/11/05 03:53:56, msw wrote: > > Does this need a dependency for javascript_dialog_extension_client_impl.cc's > > "content/public/browser/web_contents.h" include? > > Binary dependency is pulled from extensions. I can add if you want as it's > harmless. let me know. Sure, it doesn't hurt to explicitly list dependencies used directly. oshima 2014/11/05 23:22:48 Done. Show quoted text On 2014/11/05 22:59:06, msw wrote: > On 2014/11/05 21:42:19, oshima wrote: > > On 2014/11/05 03:53:56, msw wrote: > > > Does this need a dependency for javascript_dialog_extension_client_impl.cc's > > > "content/public/browser/web_contents.h" include? > > > > Binary dependency is pulled from extensions. I can add if you want as it's > > harmless. let me know. > > Sure, it doesn't hurt to explicitly list dependencies used directly. Done.
12 "//base",	12 "//components/app_modal_dialogs",

13 "//skia",

14 "//ui/views",

15 "//ui/views/controls/webview",

16 "//content/public/browser",

17 "//extensions/browser",	13 "//extensions/browser",

18 "//extensions/common",	14 "//extensions/common",

	15 "//skia",

19 ]	16 ]

20 }	17 }

OLD	NEW