Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
msw 2014/11/05 03:53:54 Perhaps everything in this file could still live i
oshima 2014/11/05 21:42:18 I put this in separate file because I thought it's
Avi (use Gerrit) 2014/11/05 21:50:40 I don't have strong opinions and would be OK eithe
msw 2014/11/05 22:59:06 I slightly favor combining the files, but don't ha
oshima 2014/11/05 23:22:48 I've moved to javascript_app_modal_dialog_android.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/app_modal_dialogs/chrome_javascript_native_dialog_fa ctory.h"
6
7 #include "base/android/jni_android.h"
8 #include "chrome/browser/ui/android/javascript_app_modal_dialog_android.h"
9 #include "components/app_modal_dialogs/javascript_dialog_manager.h"
10 #include "components/app_modal_dialogs/javascript_native_dialog_factory.h"
11
12 namespace {
13
14 class ChromeJavaScriptNativeDialogAndroidFactory
15 : public JavaScriptNativeDialogFactory {
16 public:
17 ChromeJavaScriptNativeDialogAndroidFactory() {}
18 ~ChromeJavaScriptNativeDialogAndroidFactory() override {}
19
20 private:
21 NativeAppModalDialog* CreateNativeJavaScriptDialog(
22 JavaScriptAppModalDialog* dialog,
23 gfx::NativeWindow parent_window) override {
24 return new JavascriptAppModalDialogAndroid(
25 base::android::AttachCurrentThread(),
26 dialog, parent_window);
27 }
28
29 DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogAndroidFactory);
30 };
31
32 } // namespace
33
34 void InstallChromeJavaScriptNativeDialogFactory() {
35 SetJavaScriptNativeDialogFactory(
36 make_scoped_ptr(new ChromeJavaScriptNativeDialogAndroidFactory));
37 }
38
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698