Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

components/app_modal_dialogs/javascript_dialog_manager_client.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/app_modal_dialogs/javascript_dialog_manager_client.h"
+
+namespace {
+
+JavaScriptDialogManagerClient* client = nullptr;
+
+}  //namespace
+
+void SetJavaScriptDialogManagerClient(
+    scoped_ptr<JavaScriptDialogManagerClient> new_client) {
+  delete client;
+  client = new_client.release();

[Avi (use Gerrit), 2014/10/29 17:40:57]

Wait, what?

This is clearly ownership semantics, so why would you use a scoped_ptr in the
interface (correct!) and then rip out its guts and manage the object directly?

Can't you do a LazyInstance instead, at least?

[oshima, 2014/10/31 15:54:45]

This needs to be set by embedder so we can't use Snigleton nor LazyInstance, but
I changed to set the instance to JavaScriptDialogManager impl. I hope you like
it.

+}
+
+JavaScriptDialogManagerClient* GetJavaScriptDialogManagerClient() {
+  CHECK(client);
+  return client;
+}
+