Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 625543002: Revert of Use the new java_cpp_enum rule in content. (Closed)

Created:
6 years, 2 months ago by perezju
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam, SaurabhK
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/) Reason for revert: Fails to compile on several bots: https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio First error: FAILED: cd ../../clank/native/framework; python <snip ...> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol import org.chromium.content.common.TopControlsState; ^ symbol: class TopControlsState location: package org.chromium.content.common Original issue's description: > Use the new java_cpp_enum rule in content. > > This moves most of the generated Java enums under content/ to use the > java_cpp_enum rule removing the need for keeping the enums in > separate list files and the need for the .template files. > > BUG=405532, 351558 > > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96 > Cr-Commit-Position: refs/heads/master@{#297789} TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org NOTREECHECKS=true NOTRY=true BUG=405532, 351558 Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef Cr-Commit-Position: refs/heads/master@{#297793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1119 lines, -808 lines) Patch
M android_webview/java_library_common.mk View 1 chunk +8 lines, -9 lines 0 comments Download
M android_webview/libwebviewchromium.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M build/get_landmines.py View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +20 lines, -27 lines 0 comments Download
M content/browser/android/gesture_event_type.h View 1 chunk +3 lines, -24 lines 0 comments Download
A content/browser/android/gesture_event_type_list.h View 1 chunk +33 lines, -0 lines 0 comments Download
A content/browser/android/popup_item_type_list.h View 1 chunk +23 lines, -0 lines 0 comments Download
A content/browser/gamepad/canonical_axis_index_list.h View 1 chunk +16 lines, -0 lines 0 comments Download
A content/browser/gamepad/canonical_button_index_list.h View 1 chunk +28 lines, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings.h View 1 chunk +23 lines, -29 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_linux.cc View 2 chunks +191 lines, -189 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_mac.mm View 2 chunks +245 lines, -233 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_win.cc View 2 chunks +94 lines, -89 lines 0 comments Download
M content/browser/renderer_host/input/selection_event_type.h View 1 chunk +3 lines, -14 lines 0 comments Download
A content/browser/renderer_host/input/selection_event_type_list.h View 1 chunk +23 lines, -0 lines 0 comments Download
M content/child/assert_matching_enums.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M content/content.gyp View 2 chunks +72 lines, -36 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +87 lines, -22 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/GestureEventType.template View 1 chunk +13 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SpeechRecognition.java View 5 chunks +10 lines, -11 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/SpeechRecognitionError.template View 1 chunk +11 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/GamepadDevice.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/GamepadMappings.java View 5 chunks +31 lines, -31 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/input/SelectionEventType.template View 1 chunk +13 lines, -0 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/common/ResultCodes.template View 1 chunk +13 lines, -0 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/common/TopControlsState.template View 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/common/result_codes.h View 1 chunk +3 lines, -22 lines 0 comments Download
A content/public/common/result_codes_list.h View 1 chunk +30 lines, -0 lines 0 comments Download
M content/public/common/screen_orientation_values.h View 1 chunk +3 lines, -11 lines 0 comments Download
A content/public/common/screen_orientation_values_list.h View 1 chunk +24 lines, -0 lines 0 comments Download
M content/public/common/speech_recognition_error.h View 1 chunk +3 lines, -27 lines 0 comments Download
A content/public/common/speech_recognition_error_list.h View 1 chunk +38 lines, -0 lines 0 comments Download
M content/public/common/top_controls_state.h View 1 chunk +3 lines, -5 lines 0 comments Download
A content/public/common/top_controls_state_list.h View 1 chunk +19 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl_android.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
perezju
Created Revert of Use the new java_cpp_enum rule in content.
6 years, 2 months ago (2014-10-02 09:54:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625543002/1
6 years, 2 months ago (2014-10-02 09:55:17 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-02 09:55:20 UTC) #4
Sami
lgtm.
6 years, 2 months ago (2014-10-02 10:04:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625543002/1
6 years, 2 months ago (2014-10-02 10:05:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0fcbcf848c0abd7d7c04d8f71b12583682de1c16
6 years, 2 months ago (2014-10-02 10:06:04 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef Cr-Commit-Position: refs/heads/master@{#297793}
6 years, 2 months ago (2014-10-02 10:06:37 UTC) #10
Sami
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/617103007/ by skyostil@chromium.org. ...
6 years, 2 months ago (2014-10-02 10:08:02 UTC) #11
mkosiba (inactive)
6 years, 2 months ago (2014-10-02 10:14:19 UTC) #12
Message was sent while issue was closed.
Regardless of the fact that I submitted a fix for clank immediately after this
CL landed
you should not revert upstream changes just because they break a hidden
repository.
Clank is not public, it's not possible for all of the Chromium committers to fix
it up,
if a Chromium change breaks it you should fix Clank, not revert Chromium
changes.

Powered by Google App Engine
This is Rietveld 408576698