Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 566023002: Clean up interfaces between Shader / ShaderTranslator / ANGLE side. (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up interfaces between Shader / ShaderTranslator / ANGLE side. First, it is a good cleanup to avoid an extra copy of all the variable info. Second, this cleanup will make switching to ANGLE's new APIs to query variable info much easier. BUG=401311 TEST=gpu_unittests, webgl_conformance_tests R=bajones@chromium.org,kbr@chromium.org,piman@chromium.org Committed: https://crrev.com/576a049e2372611da05e03b8ba61f4b60338cd44 Cr-Commit-Position: refs/heads/master@{#294718}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -525 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 6 chunks +18 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache_unittest.cc View 1 2 12 chunks +37 lines, -39 lines 0 comments Download
M gpu/command_buffer/service/mocks.h View 1 chunk +8 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 2 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 4 chunks +6 lines, -65 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 2 26 chunks +56 lines, -109 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 1 4 chunks +24 lines, -24 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 3 chunks +70 lines, -28 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 1 6 chunks +76 lines, -64 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 3 chunks +17 lines, -31 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 5 chunks +42 lines, -59 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_unittest.cc View 7 chunks +117 lines, -60 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 3 chunks +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 3 chunks +74 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Zhenyao Mo
This refactoring made ShaderTranslator a functional class, and do not hold temporary compilation result data ...
6 years, 3 months ago (2014-09-12 22:04:51 UTC) #1
bajones
On 2014/09/12 at 22:04:51, zmo wrote: > This refactoring made ShaderTranslator a functional class, and ...
6 years, 3 months ago (2014-09-12 23:42:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566023002/40001
6 years, 3 months ago (2014-09-13 00:01:23 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 82f76e744241a85b376c652426abc6584458849e
6 years, 3 months ago (2014-09-13 01:16:05 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 01:19:12 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/576a049e2372611da05e03b8ba61f4b60338cd44
Cr-Commit-Position: refs/heads/master@{#294718}

Powered by Google App Engine
This is Rietveld 408576698