gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc - Issue 566023002: Clean up interfaces between Shader / ShaderTranslator / ANGLE side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

Issue 566023002: Clean up interfaces between Shader / ShaderTranslator / ANGLE side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc ('k') | gpu/command_buffer/service/memory_program_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

index 9dc9fe0d8b167ab93a9e6601a0efcef3ad89e949..136834d1f9dbdbf1a7abbc58ae6a82c97688d4c3 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

@@ -1461,8 +1461,10 @@ void GLES2DecoderTestBase::SetupShader(

GL_FRAGMENT_SHADER, fragment_shader_client_id,

fragment_shader_service_id);

- GetShader(vertex_shader_client_id)->SetStatus(true, "", NULL);

- GetShader(fragment_shader_client_id)->SetStatus(true, "", NULL);

+ TestHelper::SetShaderStates(

+ gl_.get(), GetShader(vertex_shader_client_id), true);

+ TestHelper::SetShaderStates(

+ gl_.get(), GetShader(fragment_shader_client_id), true);

cmds::AttachShader attach_cmd;

attach_cmd.Init(program_client_id, vertex_shader_client_id);

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc ('k') | gpu/command_buffer/service/memory_program_cache.cc » ('j') | no next file with comments »