Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 543553002: [Checkstyle] Enable additional name checks for Java. (Closed)

Created:
6 years, 3 months ago by aurimas (slooooooooow)
Modified:
6 years, 3 months ago
Reviewers:
Ted C, qinmin, boliu
CC:
chromium-reviews, cbentzel+watch_chromium.org, feature-media-reviews_chromium.org, riju_, jam, timvolodine, avayvod+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, Michael van Ouwerkerk, klundberg+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/b278b52d9e92ad44cbdc9a4258bb0fd04d603eb6 Cr-Commit-Position: refs/heads/master@{#293354}

Patch Set 1 #

Patch Set 2 : Undo changes in net/* #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -187 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 3 chunks +6 lines, -6 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/JavaBrowserViewRendererHelper.java View 1 chunk +3 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 7 chunks +17 lines, -19 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java View 1 chunk +10 lines, -10 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 5 chunks +31 lines, -31 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java View 4 chunks +5 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 4 chunks +20 lines, -20 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java View 10 chunks +17 lines, -17 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/KeyNavigationUtil.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarksUriTest.java View 3 chunks +26 lines, -26 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java View 1 chunk +6 lines, -6 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/DeviceSensorsTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/UsbMidiDeviceAndroid.java View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/webaudio_media_codec_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 3 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
aurimas (slooooooooow)
boliu@chromium.org: Please review changes in android_webview/* tedchoc@chromium.org: Please review changes in the rest of the ...
6 years, 3 months ago (2014-09-04 03:24:10 UTC) #2
aurimas (slooooooooow)
qinmin@chromium.org: Please review changes in media/*
6 years, 3 months ago (2014-09-04 03:24:47 UTC) #5
aurimas (slooooooooow)
qinmin@chromium.org: Please review changes in media/*
6 years, 3 months ago (2014-09-04 03:24:47 UTC) #6
boliu
lgtm
6 years, 3 months ago (2014-09-04 03:29:01 UTC) #7
Ted C
lgtm
6 years, 3 months ago (2014-09-04 17:13:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/543553002/20001
6 years, 3 months ago (2014-09-04 17:18:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53647) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8757)
6 years, 3 months ago (2014-09-04 19:18:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/543553002/20001
6 years, 3 months ago (2014-09-04 19:23:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8785)
6 years, 3 months ago (2014-09-04 21:13:54 UTC) #16
qinmin
On 2014/09/04 21:13:54, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-04 21:16:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/543553002/40001
6 years, 3 months ago (2014-09-04 22:15:26 UTC) #19
commit-bot: I haz the power
Failed to apply patch for android_webview/java/src/org/chromium/android_webview/AwContents.java: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-04 22:16:59 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:14 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b278b52d9e92ad44cbdc9a4258bb0fd04d603eb6
Cr-Commit-Position: refs/heads/master@{#293354}

Powered by Google App Engine
This is Rietveld 408576698