content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java - Issue 543553002: [Checkstyle] Enable additional name checks for Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java

Issue 543553002: [Checkstyle] Enable additional name checks for Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/DeviceSensorsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java

index a569e55bdbeb10d437204134336060cbd1219f2c..e5c147d9d7c3bfb007cc62d4995e0971c5318b8b 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java

@@ -105,15 +105,15 @@ public class ContentViewScrollingTest extends ContentShellTestBase {

@Override

public boolean isSatisfied() {

// Scrolling and flinging don't result in exact coordinates.

- final int MIN_THRESHOLD = 5;

- final int MAX_THRESHOLD = 100;

+ final int minThreshold = 5;

+ final int maxThreshold = 100;

boolean xCorrect = hugLeft ?

- getContentViewCore().getNativeScrollXForTest() < MIN_THRESHOLD :

- getContentViewCore().getNativeScrollXForTest() > MAX_THRESHOLD;

+ getContentViewCore().getNativeScrollXForTest() < minThreshold :

+ getContentViewCore().getNativeScrollXForTest() > maxThreshold;

boolean yCorrect = hugTop ?

- getContentViewCore().getNativeScrollYForTest() < MIN_THRESHOLD :

- getContentViewCore().getNativeScrollYForTest() > MAX_THRESHOLD;

+ getContentViewCore().getNativeScrollYForTest() < minThreshold :

+ getContentViewCore().getNativeScrollYForTest() > maxThreshold;

return xCorrect && yCorrect;

}

}));