android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java - Issue 543553002: [Checkstyle] Enable additional name checks for Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java

Issue 543553002: [Checkstyle] Enable additional name checks for Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java

index a595d3f9b667cf6f7430ff74e40708bf62d6a0e7..5c55fdf9743af4512153652a7dca90d37ba97fbc 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java

@@ -21,7 +21,7 @@ import org.chromium.components.web_contents_delegate_android.WebContentsDelegate

public abstract class AwWebContentsDelegate extends WebContentsDelegateAndroid {

// Callback filesSelectedInChooser() when done.

@CalledByNative

- public abstract void runFileChooser(int processId, int renderId, int mode_flags,

+ public abstract void runFileChooser(int processId, int renderId, int modeFlags,

String acceptTypes, String title, String defaultFilename, boolean capture);

@CalledByNative

@@ -41,5 +41,5 @@ public abstract class AwWebContentsDelegate extends WebContentsDelegateAndroid {

// Call in response to a prior runFileChooser call.

protected static native void nativeFilesSelectedInChooser(int processId, int renderId,

- int mode_flags, String[] filePath, String[] displayName);

+ int modeFlags, String[] filePath, String[] displayName);

}