android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java - Issue 543553002: [Checkstyle] Enable additional name checks for Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

Issue 543553002: [Checkstyle] Enable additional name checks for Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

index 6a15244bb79db2a4c12a869017d8bba3f0219716..253a361aa39997c0b3fca27c190ee3a06d2ae953 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

@@ -27,7 +27,7 @@ public class AwJavaBridgeTest extends AwTestBase {

@SmallTest

@Feature({"AndroidWebView", "Android-JavaBridge"})

public void testDestroyFromJavaObject() throws Throwable {

- final String HTML = "<html>Hello World</html>";

+ final String html = "<html>Hello World</html>";

final TestAwContentsClient client2 = new TestAwContentsClient();

final AwTestContainerView view2 = createAwTestContainerViewOnMainSync(client2);

final AwContents awContents = mTestContainerView.getAwContents();

@@ -45,7 +45,7 @@ public class AwJavaBridgeTest extends AwTestBase {

// Destroying one AwContents from within the JS callback should still

// leave others functioning.

loadDataSync(view2.getAwContents(), client2.getOnPageFinishedHelper(),

- HTML, "text/html", false);

+ html, "text/html", false);

} catch (Throwable t) {

throw new RuntimeException(t);

}

@@ -60,7 +60,7 @@ public class AwJavaBridgeTest extends AwTestBase {

}

});

- loadDataSync(awContents, mContentsClient.getOnPageFinishedHelper(), HTML,

+ loadDataSync(awContents, mContentsClient.getOnPageFinishedHelper(), html,

"text/html", false);

// Ensure the JS interface object is there, and invoke the test method.