content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java - Issue 543553002: [Checkstyle] Enable additional name checks for Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java

Issue 543553002: [Checkstyle] Enable additional name checks for Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/DeviceSensorsTest.java ('k') | content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java b/content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java

index f15c4e60e8bca5c59cee92c8f424aeaab8c94c23..b0e273002a9bdf3fef212107c185518fdf51767e 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java

@@ -100,12 +100,12 @@ public class NavigationTest extends ContentShellTestBase {

@MediumTest

@Feature({"Navigation"})

public void testPageReload() throws Throwable {

- final String HTML_LOADTIME = "<html><head>" +

+ final String htmlLoadTime = "<html><head>" +

"<script type=\"text/javascript\">var loadTimestamp = new Date().getTime();" +

"function getLoadtime() { return loadTimestamp; }</script></head></html>";

- final String URL_LOADTIME = UrlUtils.encodeHtmlDataUri(HTML_LOADTIME);

+ final String urlLoadTime = UrlUtils.encodeHtmlDataUri(htmlLoadTime);

- ContentShellActivity activity = launchContentShellWithUrl(URL_LOADTIME);

+ ContentShellActivity activity = launchContentShellWithUrl(urlLoadTime);

waitForActiveShellToBeDoneLoading();

ContentViewCore contentViewCore = activity.getActiveContentViewCore();

TestCallbackHelperContainer testCallbackHelperContainer =