android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java - Issue 543553002: [Checkstyle] Enable additional name checks for Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java

Issue 543553002: [Checkstyle] Enable additional name checks for Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java

index 8ea8630310c93e5193eea319de647d2d1886011a..f1e846a565e2b2f3af3ab030c6c54ebf4665d421 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java

@@ -140,20 +140,20 @@ public class AwQuotaManagerBridgeTest extends AwTestBase {

}

private void useAppCache() throws Exception {

- final String CACHED_FILE_PATH = "/foo.js";

- final String CACHED_FILE_CONTENTS = "1 + 1;";

- mWebServer.setResponse(CACHED_FILE_PATH, CACHED_FILE_CONTENTS, null);

+ final String cachedFilePath = "/foo.js";

+ final String cachedFileContents = "1 + 1;";

+ mWebServer.setResponse(cachedFilePath, cachedFileContents, null);

- final String MANIFEST_PATH = "/foo.manifest";

- final String MANIFEST_CONTENTS = "CACHE MANIFEST\nCACHE:\n" + CACHED_FILE_PATH;

+ final String manifestPath = "/foo.manifest";

+ final String manifestContents = "CACHE MANIFEST\nCACHE:\n" + cachedFilePath;

List<Pair<String, String>> manifestHeaders = new ArrayList<Pair<String, String>>();

manifestHeaders.add(Pair.create("Content-Disposition", "text/cache-manifest"));

- mWebServer.setResponse(MANIFEST_PATH, MANIFEST_CONTENTS, manifestHeaders);

+ mWebServer.setResponse(manifestPath, manifestContents, manifestHeaders);

- final String PAGE_PATH = "/appcache.html";

- final String PAGE_CONTENTS = "<html manifest=\"" + MANIFEST_PATH + "\">" +

- "<head><script src=\"" + CACHED_FILE_PATH + "\"></script></head></html>";

- String url = mWebServer.setResponse(PAGE_PATH, PAGE_CONTENTS, null);

+ final String pagePath = "/appcache.html";

+ final String pageContents = "<html manifest=\"" + manifestPath + "\">" +

+ "<head><script src=\"" + cachedFilePath + "\"></script></head></html>";

+ String url = mWebServer.setResponse(pagePath, pageContents, null);

loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), url);

executeJavaScriptAndWaitForResult(mAwContents, mContentsClient,