| OLD | NEW |
| 1 <?xml version="1.0" encoding="UTF-8"?> | 1 <?xml version="1.0" encoding="UTF-8"?> |
| 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http:
//www.puppycrawl.com/dtds/configuration_1_3.dtd"> | 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http:
//www.puppycrawl.com/dtds/configuration_1_3.dtd"> |
| 3 | 3 |
| 4 <!-- | 4 <!-- |
| 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che
ckstyle | 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che
ckstyle |
| 6 --> | 6 --> |
| 7 <module name="Checker"> | 7 <module name="Checker"> |
| 8 <property name="severity" value="warning"/> | 8 <property name="severity" value="warning"/> |
| 9 <property name="charset" value="UTF-8"/> | 9 <property name="charset" value="UTF-8"/> |
| 10 <module name="TreeWalker"> | 10 <module name="TreeWalker"> |
| (...skipping 24 matching lines...) Expand all Loading... |
| 35 <property name="allowMissingParamTags" value="true"/> | 35 <property name="allowMissingParamTags" value="true"/> |
| 36 <property name="allowMissingPropertyJavadoc" value="true"/> | 36 <property name="allowMissingPropertyJavadoc" value="true"/> |
| 37 <property name="allowMissingReturnTag" value="true"/> | 37 <property name="allowMissingReturnTag" value="true"/> |
| 38 <property name="allowMissingThrowsTags" value="true"/> | 38 <property name="allowMissingThrowsTags" value="true"/> |
| 39 </module> | 39 </module> |
| 40 <module name="PackageName"> | 40 <module name="PackageName"> |
| 41 <property name="severity" value="error"/> | 41 <property name="severity" value="error"/> |
| 42 <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]{1,})*$"/> | 42 <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]{1,})*$"/> |
| 43 </module> | 43 </module> |
| 44 <module name="TypeName"> | 44 <module name="TypeName"> |
| 45 <property name="severity" value="warning"/> | 45 <property name="severity" value="error"/> |
| 46 </module> | 46 </module> |
| 47 <module name="ConstantName"> | 47 <module name="ConstantName"> |
| 48 <property name="severity" value="error"/> | 48 <property name="severity" value="error"/> |
| 49 <property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA
-Z0-9]*)$"/> | 49 <property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA
-Z0-9]*)$"/> |
| 50 <message key="name.invalidPattern" value="Static final field names must ei
ther be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g
. AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state
or that don't 'feel' like constants."/> | 50 <message key="name.invalidPattern" value="Static final field names must ei
ther be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g
. AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state
or that don't 'feel' like constants."/> |
| 51 </module> | 51 </module> |
| 52 <!-- Non-public, non-static field names start with m. --> | 52 <!-- Non-public, non-static field names start with m. --> |
| 53 <module name="MemberName"> | 53 <module name="MemberName"> |
| 54 <property name="severity" value="error"/> | 54 <property name="severity" value="error"/> |
| 55 <property name="format" value="^m[A-Z][a-zA-Z0-9]*$"/> | 55 <property name="format" value="^m[A-Z][a-zA-Z0-9]*$"/> |
| 56 <property name="applyToPublic" value="false"/> | 56 <property name="applyToPublic" value="false"/> |
| 57 <message key="name.invalidPattern" value="Non-public, non-static field n
ames start with m."/> | 57 <message key="name.invalidPattern" value="Non-public, non-static field n
ames start with m."/> |
| 58 </module> | 58 </module> |
| 59 <!-- Static field names start with s. --> | 59 <!-- Static field names start with s. --> |
| 60 <module name="StaticVariableName"> | 60 <module name="StaticVariableName"> |
| 61 <property name="severity" value="error"/> | 61 <property name="severity" value="error"/> |
| 62 <property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/> | 62 <property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/> |
| 63 <property name="applyToPublic" value="false"/> | 63 <property name="applyToPublic" value="false"/> |
| 64 <message key="name.invalidPattern" value="Static field names start with
s."/> | 64 <message key="name.invalidPattern" value="Static field names start with
s."/> |
| 65 </module> | 65 </module> |
| 66 <module name="MethodName" /> | 66 <module name="MethodName"> |
| 67 <property name="severity" value="error"/> |
| 68 <property name="format" value="^[a-z][a-zA-Z0-9_]*$"/> |
| 69 <message key="name.invalidPattern" value="Method names should start with
a lower case letter (e.g. getWidth())"/> |
| 70 </module> |
| 67 <module name="ParameterName"> | 71 <module name="ParameterName"> |
| 68 <property name="severity" value="warning"/> | 72 <property name="severity" value="error"/> |
| 69 </module> | 73 </module> |
| 70 <module name="LocalFinalVariableName"> | 74 <module name="LocalFinalVariableName"> |
| 71 <property name="severity" value="warning"/> | 75 <property name="severity" value="error"/> |
| 76 <property name="format" value="^m|s|((([ms][a-z0-9])|([a-ln-rt-z]))[a-zA-Z
0-9]*)$"/> |
| 77 <message key="name.invalidPattern" value="Local variables should be camel-
cased (e.g. int minWidth = 4)."/> |
| 72 </module> | 78 </module> |
| 73 <module name="LocalVariableName"> | 79 <module name="LocalVariableName"> |
| 74 <property name="severity" value="warning"/> | 80 <property name="severity" value="error"/> |
| 81 <property name="format" value="^m|s|((([ms][a-z0-9])|([a-ln-rt-z]))[a-zA-Z
0-9]*)$"/> |
| 82 <message key="name.invalidPattern" value="Local variables should be camel-
cased (e.g. int minWidth = 4)."/> |
| 75 </module> | 83 </module> |
| 76 <module name="LineLength"> | 84 <module name="LineLength"> |
| 77 <property name="severity" value="error"/> | 85 <property name="severity" value="error"/> |
| 78 <property name="ignorePattern" value="^import.*$" /> | 86 <property name="ignorePattern" value="^import.*$" /> |
| 79 <property name="max" value="100"/> | 87 <property name="max" value="100"/> |
| 80 </module> | 88 </module> |
| 81 <module name="LeftCurly"> | 89 <module name="LeftCurly"> |
| 82 <property name="severity" value="warning"/> | 90 <property name="severity" value="warning"/> |
| 83 </module> | 91 </module> |
| 84 <module name="RightCurly"> | 92 <module name="RightCurly"> |
| (...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 128 <property name="severity" value="warning"/> | 136 <property name="severity" value="warning"/> |
| 129 </module> | 137 </module> |
| 130 <module name="ImportOrder"> | 138 <module name="ImportOrder"> |
| 131 <property name="severity" value="error"/> | 139 <property name="severity" value="error"/> |
| 132 <message key="import.ordering" value="Wrong order for {0} import. Use :Jav
aImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/> | 140 <message key="import.ordering" value="Wrong order for {0} import. Use :Jav
aImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/> |
| 133 <property name="groups" value="android, com, dalvik, gov, junit, libcore,
net, org, java, javax"/> | 141 <property name="groups" value="android, com, dalvik, gov, junit, libcore,
net, org, java, javax"/> |
| 134 <property name="ordered" value="true"/> | 142 <property name="ordered" value="true"/> |
| 135 <property name="option" value="top"/> | 143 <property name="option" value="top"/> |
| 136 <property name="separated" value="true"/> | 144 <property name="separated" value="true"/> |
| 137 </module> | 145 </module> |
| 146 <!-- TODO(aurimas): make indentation an error once https://github.com/checks
tyle/checkstyle/issues/255 is fixed. --> |
| 138 <module name="Indentation"> | 147 <module name="Indentation"> |
| 148 <property name="severity" value="warning"/> |
| 139 <property name="basicOffset" value="4"/> | 149 <property name="basicOffset" value="4"/> |
| 150 <property name="throwsIndent" value="8"/> |
| 140 </module> | 151 </module> |
| 141 </module> | 152 </module> |
| 142 <module name="FileTabCharacter"/> | 153 <module name="FileTabCharacter"/> |
| 143 <module name="RegexpSingleline"> | 154 <module name="RegexpSingleline"> |
| 144 <property name="format" value="((//.*)|(\*.*))FIXME"/> | 155 <property name="format" value="((//.*)|(\*.*))FIXME"/> |
| 145 <property name="message" value="TODO is preferred to FIXME. e.g. "TODO
(johndoe):"/> | 156 <property name="message" value="TODO is preferred to FIXME. e.g. "TODO
(johndoe):"/> |
| 146 </module> | 157 </module> |
| 147 <module name="RegexpSingleline"> | 158 <module name="RegexpSingleline"> |
| 148 <property name="format" value="((//.*)|(\*.*))(?<!TODO\(.{0,100})(TODO[^(
])|(TODO\([^)]*$)"/> | 159 <property name="format" value="((//.*)|(\*.*))(?<!TODO\(.{0,100})(TODO[^(
])|(TODO\([^)]*$)"/> |
| 149 <property name="message" value="All TODOs should be named. e.g. "TODO(
johndoe):"/> | 160 <property name="message" value="All TODOs should be named. e.g. "TODO(
johndoe):"/> |
| 150 </module> | 161 </module> |
| 151 <module name="RegexpSingleline"> | 162 <module name="RegexpSingleline"> |
| 152 <property name="severity" value="error"/> | 163 <property name="severity" value="error"/> |
| 153 <property name="format" value="[ \t]+$"/> | 164 <property name="format" value="[ \t]+$"/> |
| 154 <property name="message" value="Trailing whitespace"/> | 165 <property name="message" value="Trailing whitespace"/> |
| 155 </module> | 166 </module> |
| 156 <module name="RegexpHeader"> | 167 <module name="RegexpHeader"> |
| 157 <property name="severity" value="error"/> | 168 <property name="severity" value="error"/> |
| 158 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al
l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice
nse that can be$\n^// found in the LICENSE file.$"/> | 169 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al
l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice
nse that can be$\n^// found in the LICENSE file.$"/> |
| 159 </module> | 170 </module> |
| 160 </module> | 171 </module> |
| OLD | NEW |