chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java - Issue 543553002: [Checkstyle] Enable additional name checks for Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java

Issue 543553002: [Checkstyle] Enable additional name checks for Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarksUriTest.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java

index 656fbea92e42732611ae3e33e0bc726b88f9291b..0bf48f011bf83f87813ecf8b76bf89aa1eed8b2f 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java

@@ -145,7 +145,7 @@ public class ProviderSearchesUriTest extends ProviderTestBase {

@DisabledTest

public void testSearchesTable() {

- final int ID_INDEX = 0;

+ final int idIndex = 0;

String insertSearch = "search_insert";

String updateSearch = "search_update";

@@ -164,7 +164,7 @@ public class ProviderSearchesUriTest extends ProviderTestBase {

cursor.getString(Browser.SEARCHES_PROJECTION_SEARCH_INDEX));

assertEquals(createDate,

cursor.getLong(Browser.SEARCHES_PROJECTION_DATE_INDEX));

- int id = cursor.getInt(ID_INDEX);

+ int id = cursor.getInt(idIndex);

cursor.close();

// Test: update

@@ -183,7 +183,7 @@ public class ProviderSearchesUriTest extends ProviderTestBase {

cursor.getString(Browser.SEARCHES_PROJECTION_SEARCH_INDEX));

assertEquals(updateDate,

cursor.getLong(Browser.SEARCHES_PROJECTION_DATE_INDEX));

- assertEquals(id, cursor.getInt(ID_INDEX));

+ assertEquals(id, cursor.getInt(idIndex));

// Test: delete

getContentResolver().delete(insertUri, null, null);