Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva, sky
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, tfarina, browser-components-watch_chromium.org, dcheng, rginda+watch_chromium.org, yoshiki+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, pedrosimonetti+watch_chromium.org, blundell, sdefresne, nshaik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move bookmark_pref_names.* into bookmarks namespace. BUG=370433 TEST=None R=sky@chromium.org TBR=joaodasilva@chromium.org Committed: https://crrev.com/3bddbe11616e0d00aab25fa0190d84627a73a5fd Cr-Commit-Position: refs/heads/master@{#292324}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : fix extensions? #

Patch Set 4 : fix #

Patch Set 5 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -139 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc View 6 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/profile_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/prefs/pref_functional_browsertest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 1 4 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M components/bookmarks/common/bookmark_pref_names.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/bookmarks/common/bookmark_pref_names.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/policy/core/browser/managed_bookmarks_tracker.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/policy/core/browser/managed_bookmarks_tracker_unittest.cc View 1 2 3 4 13 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
tfarina
6 years, 4 months ago (2014-08-25 02:17:22 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-25 15:33:59 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-27 13:54:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/490123003/20001
6 years, 3 months ago (2014-08-27 13:54:47 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-27 14:32:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/490123003/40001
6 years, 3 months ago (2014-08-27 14:34:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 15:24:01 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 15:27:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/7001)
6 years, 3 months ago (2014-08-27 15:27:11 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-27 23:04:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/490123003/60001
6 years, 3 months ago (2014-08-27 23:06:00 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 23:27:06 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:28:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/9772) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/9773) ios_rel_device_ninja ...
6 years, 3 months ago (2014-08-27 23:28:50 UTC) #14
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-28 01:38:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/490123003/80001
6 years, 3 months ago (2014-08-28 01:38:54 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 02:36:04 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 02:39:10 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/7224)
6 years, 3 months ago (2014-08-28 02:39:12 UTC) #19
tfarina
tfarina@chromium.org changed reviewers: + joaodasilva@chromium.org
6 years, 3 months ago (2014-08-28 03:02:45 UTC) #20
tfarina
TBRing Joao da Silva for components/policy.
6 years, 3 months ago (2014-08-28 03:02:46 UTC) #21
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-28 03:03:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/490123003/80001
6 years, 3 months ago (2014-08-28 03:03:53 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 04:29:19 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 325e92d8886450efc8bc268350bfc9919fa6e87e
6 years, 3 months ago (2014-08-28 05:29:47 UTC) #25
Joao da Silva
policy/ lgtm
6 years, 3 months ago (2014-08-28 09:47:03 UTC) #26
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:40 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3bddbe11616e0d00aab25fa0190d84627a73a5fd
Cr-Commit-Position: refs/heads/master@{#292324}

Powered by Google App Engine
This is Rietveld 408576698