chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index 07fe0ceec27f60f50e8f0cc553e7370e71751c29..685c00b4fbba6ac07dbeb5646403cb7e904c5d0d 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -606,7 +606,7 @@ void RecordAppLaunch(Profile* profile, GURL url) {

- (BOOL)canEditBookmarks {

PrefService* prefs = browser_->profile()->GetPrefs();

- return prefs->GetBoolean(prefs::kEditBookmarksEnabled);

+ return prefs->GetBoolean(bookmarks::prefs::kEditBookmarksEnabled);

}

- (BOOL)canEditBookmark:(const BookmarkNode*)node {

@@ -1178,8 +1178,9 @@ void RecordAppLaunch(Profile* profile, GURL url) {

return NO;

PrefService* prefs = browser_->profile()->GetPrefs();

- BOOL visible = ![managedBookmarksButton_ bookmarkNode]->empty() &&

- prefs->GetBoolean(prefs::kShowManagedBookmarksInBookmarkBar);

+ BOOL visible =

+ ![managedBookmarksButton_ bookmarkNode]->empty() &&

+ prefs->GetBoolean(bookmarks::prefs::kShowManagedBookmarksInBookmarkBar);

BOOL currentVisibility = ![managedBookmarksButton_ isHidden];

if (currentVisibility != visible) {

[managedBookmarksButton_ setHidden:!visible];