chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc - Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc ('k') | chrome/browser/ui/bookmarks/bookmark_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

index b8798c25d58077decd6f08c33170ee163cebed18..5206a3e576bdc904a0d5e22de8d5634ef97eaaf8 100644

--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

@@ -349,19 +349,19 @@ TEST_F(BookmarkContextMenuControllerTest,

// By default, the pref is not managed and the command is enabled.

TestingPrefServiceSyncable* prefs = profile_->GetTestingPrefService();

- EXPECT_FALSE(

- prefs->IsManagedPreference(prefs::kShowAppsShortcutInBookmarkBar));

+ EXPECT_FALSE(prefs->IsManagedPreference(

+ bookmarks::prefs::kShowAppsShortcutInBookmarkBar));

EXPECT_TRUE(

controller.IsCommandIdEnabled(IDC_BOOKMARK_BAR_SHOW_APPS_SHORTCUT));

// Disabling the shorcut by policy disables the command.

- prefs->SetManagedPref(prefs::kShowAppsShortcutInBookmarkBar,

+ prefs->SetManagedPref(bookmarks::prefs::kShowAppsShortcutInBookmarkBar,

new base::FundamentalValue(false));

EXPECT_FALSE(

controller.IsCommandIdEnabled(IDC_BOOKMARK_BAR_SHOW_APPS_SHORTCUT));

// And enabling the shortcut by policy disables the command too.

- prefs->SetManagedPref(prefs::kShowAppsShortcutInBookmarkBar,

+ prefs->SetManagedPref(bookmarks::prefs::kShowAppsShortcutInBookmarkBar,

new base::FundamentalValue(true));

EXPECT_FALSE(

controller.IsCommandIdEnabled(IDC_BOOKMARK_BAR_SHOW_APPS_SHORTCUT));