chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc - Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

index c7c0fc7d394ddabdb551918f4e5a4ce4f933cbf2..a1460489817ababa2a84be79e0df2ac56c44d90f 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

@@ -43,7 +43,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) {

node->SetString("name", "Managed Folder");

node->Set("children", new base::ListValue());

list.Append(node);

- profile->GetPrefs()->Set(prefs::kManagedBookmarks, list);

+ profile->GetPrefs()->Set(bookmarks::prefs::kManagedBookmarks, list);

ASSERT_EQ(2, client->managed_node()->child_count());

ASSERT_TRUE(RunComponentExtensionTest("bookmark_manager/standard"))

@@ -66,7 +66,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BookmarkManagerEditDisabled) {

GURL("http://bbb.example.com"));

PrefService* prefs = user_prefs::UserPrefs::Get(profile);

- prefs->SetBoolean(prefs::kEditBookmarksEnabled, false);

+ prefs->SetBoolean(bookmarks::prefs::kEditBookmarksEnabled, false);

ASSERT_TRUE(RunComponentExtensionTest("bookmark_manager/edit_disabled"))

<< message_;