Move bookmark_pref_names.* into bookmarks namespace.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/string16.h"
@@ skipping 1516 matching lines @@
   EXPECT_FALSE([view isHidden]);
   [bar_ shrinkOrHideView:view forMaxX:31.0];
   EXPECT_EQ(31.0, NSWidth([view frame]));
   EXPECT_FALSE([view isHidden]);
   [bar_ shrinkOrHideView:view forMaxX:29.0];
   EXPECT_TRUE([view isHidden]);
 }
 
 TEST_F(BookmarkBarControllerTest, LastBookmarkResizeBehavior) {
   // Hide the apps shortcut.
-  profile()->GetPrefs()->SetBoolean(prefs::kShowAppsShortcutInBookmarkBar,
-                                    false);
+  profile()->GetPrefs()->SetBoolean(
+      bookmarks::prefs::kShowAppsShortcutInBookmarkBar, false);
   ASSERT_TRUE([bar_ appsPageShortcutButtonIsHidden]);
 
   BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
   const BookmarkNode* root = model->bookmark_bar_node();
   const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b ");
   test::AddNodesFromModelString(model, root, model_string);
   [bar_ frameDidChange];
 
   CGFloat viewWidths[] = { 123.0, 124.0, 151.0, 152.0, 153.0, 154.0, 155.0,
                            200.0, 155.0, 154.0, 153.0, 152.0, 151.0, 124.0,
@@ skipping 27 matching lines @@
   // Bookmarks should be to the right of the Apps page shortcut button.
   CGFloat apps_button_right = NSMaxX([[bar_ appsPageShortcutButton] frame]);
   CGFloat right = apps_button_right;
   NSArray* buttons = [bar_ buttons];
   for (size_t i = 0; i < [buttons count]; ++i) {
     EXPECT_LE(right, NSMinX([[buttons objectAtIndex:i] frame]));
     right = NSMaxX([[buttons objectAtIndex:i] frame]);
   }
 
   // Removing the Apps button should move every bookmark to the left.
-  profile()->GetPrefs()->SetBoolean(prefs::kShowAppsShortcutInBookmarkBar,
-                                    false);
+  profile()->GetPrefs()->SetBoolean(
+      bookmarks::prefs::kShowAppsShortcutInBookmarkBar, false);
   ASSERT_TRUE([bar_ appsPageShortcutButtonIsHidden]);
   EXPECT_GT(apps_button_right, NSMinX([[buttons objectAtIndex:0] frame]));
   for (size_t i = 1; i < [buttons count]; ++i) {
     EXPECT_LE(NSMaxX([[buttons objectAtIndex:i - 1] frame]),
               NSMinX([[buttons objectAtIndex:i] frame]));
   }
 }
 
 TEST_F(BookmarkBarControllerTest, BookmarksWithoutAppsPageShortcut) {
   // The no item containers should be to the right of the Apps button.
   ASSERT_FALSE([bar_ appsPageShortcutButtonIsHidden]);
   CGFloat apps_button_right = NSMaxX([[bar_ appsPageShortcutButton] frame]);
   EXPECT_LE(apps_button_right,
             NSMinX([[[bar_ buttonView] noItemTextfield] frame]));
   EXPECT_LE(NSMaxX([[[bar_ buttonView] noItemTextfield] frame]),
             NSMinX([[[bar_ buttonView] importBookmarksButton] frame]));
 
   // Removing the Apps button should move the no item containers to the left.
-  profile()->GetPrefs()->SetBoolean(prefs::kShowAppsShortcutInBookmarkBar,
-                                    false);
+  profile()->GetPrefs()->SetBoolean(
+      bookmarks::prefs::kShowAppsShortcutInBookmarkBar, false);
   ASSERT_TRUE([bar_ appsPageShortcutButtonIsHidden]);
   EXPECT_GT(apps_button_right,
             NSMinX([[[bar_ buttonView] noItemTextfield] frame]));
   EXPECT_LE(NSMaxX([[[bar_ buttonView] noItemTextfield] frame]),
             NSMinX([[[bar_ buttonView] importBookmarksButton] frame]));
 }
 
 TEST_F(BookmarkBarControllerTest, ManagedShowAppsShortcutInBookmarksBar) {
   // By default the pref is not managed and the apps shortcut is shown.
   TestingPrefServiceSyncable* prefs = profile()->GetTestingPrefService();
-  EXPECT_FALSE(
-      prefs->IsManagedPreference(prefs::kShowAppsShortcutInBookmarkBar));
+  EXPECT_FALSE(prefs->IsManagedPreference(
+      bookmarks::prefs::kShowAppsShortcutInBookmarkBar));
   EXPECT_FALSE([bar_ appsPageShortcutButtonIsHidden]);
 
   // Hide the apps shortcut by policy, via the managed pref.
-  prefs->SetManagedPref(prefs::kShowAppsShortcutInBookmarkBar,
+  prefs->SetManagedPref(bookmarks::prefs::kShowAppsShortcutInBookmarkBar,
                         new base::FundamentalValue(false));
   EXPECT_TRUE([bar_ appsPageShortcutButtonIsHidden]);
 
   // And try showing it via policy too.
-  prefs->SetManagedPref(prefs::kShowAppsShortcutInBookmarkBar,
+  prefs->SetManagedPref(bookmarks::prefs::kShowAppsShortcutInBookmarkBar,
                         new base::FundamentalValue(true));
   EXPECT_FALSE([bar_ appsPageShortcutButtonIsHidden]);
 }
 
 class BookmarkBarControllerOpenAllTest : public BookmarkBarControllerTest {
 public:
   virtual void SetUp() {
     BookmarkBarControllerTest::SetUp();
     ASSERT_TRUE(profile());
 
@@ skipping 357 matching lines @@
   EXPECT_EQ(expectedController, actualController);
 }
 
 TEST_F(BookmarkBarControllerDragDropTest, DropPositionIndicator) {
   BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
   const BookmarkNode* root = model->bookmark_bar_node();
   const std::string model_string("1b 2f:[ 2f1b 2f2b 2f3b ] 3b 4b ");
   test::AddNodesFromModelString(model, root, model_string);
 
   // Hide the apps shortcut.
-  profile()->GetPrefs()->SetBoolean(prefs::kShowAppsShortcutInBookmarkBar,
-                                    false);
+  profile()->GetPrefs()->SetBoolean(
+      bookmarks::prefs::kShowAppsShortcutInBookmarkBar, false);
   ASSERT_TRUE([bar_ appsPageShortcutButtonIsHidden]);
 
   // Validate initial model.
   std::string actualModel = test::ModelStringFromNode(root);
   EXPECT_EQ(model_string, actualModel);
 
   // Test a series of points starting at the right edge of the bar.
   BookmarkButton* targetButton = [bar_ buttonWithTitleEqualTo:@"1b"];
   ASSERT_TRUE(targetButton);
   NSPoint targetPoint = [targetButton left];
@@ skipping 79 matching lines @@
                              "2f3b ] 4b ");
   actual = test::ModelStringFromNode(root);
   EXPECT_EQ(expected, actual);
 
   // Verify that the other bookmark folder can't be deleted.
   BookmarkButton *otherButton = [bar_ otherBookmarksButton];
   EXPECT_FALSE([bar_ canDragBookmarkButtonToTrash:otherButton]);
 }
 
 }  // namespace