chrome/browser/autocomplete/search_provider_unittest.cc - Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc ('k') | chrome/browser/bookmarks/bookmark_model_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/search_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc

index 5742649d078f2c4be4444eb4e168d34d9561828b..1d24a24fd0e7485b533398cf83374de03b2dfbe4 100644

--- a/chrome/browser/autocomplete/search_provider_unittest.cc

+++ b/chrome/browser/autocomplete/search_provider_unittest.cc

@@ -2917,7 +2917,7 @@ TEST_F(SearchProviderTest, ParseDeletionUrl) {

}

TEST_F(SearchProviderTest, ReflectsBookmarkBarState) {

- profile_.GetPrefs()->SetBoolean(prefs::kShowBookmarkBar, false);

+ profile_.GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, false);

base::string16 term = term1_.substr(0, term1_.length() - 1);

QueryForInput(term, true, false);

ASSERT_FALSE(provider_->matches().empty());

@@ -2926,7 +2926,7 @@ TEST_F(SearchProviderTest, ReflectsBookmarkBarState) {

ASSERT_TRUE(provider_->matches()[0].search_terms_args != NULL);

EXPECT_FALSE(provider_->matches()[0].search_terms_args->bookmark_bar_pinned);

- profile_.GetPrefs()->SetBoolean(prefs::kShowBookmarkBar, true);

+ profile_.GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, true);

term = term1_.substr(0, term1_.length() - 1);

QueryForInput(term, true, false);

ASSERT_FALSE(provider_->matches().empty());