chrome/browser/ui/browser_commands.cc - Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index fbd211b945da6567a12f91d43ac75dca6589610f..aeb0d61321449e47bc22df252f60f3c580233cce 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -120,7 +120,7 @@ bool CanBookmarkCurrentPageInternal(const Browser* browser,

BookmarkModelFactory::GetForProfile(browser->profile());

return browser_defaults::bookmarks_enabled &&

browser->profile()->GetPrefs()->GetBoolean(

- prefs::kEditBookmarksEnabled) &&

+ bookmarks::prefs::kEditBookmarksEnabled) &&

model && model->loaded() && browser->is_type_tabbed() &&

(!check_remove_bookmark_ui ||

!chrome::ShouldRemoveBookmarkThisPageUI(browser->profile()));

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm » ('j') | no next file with comments »