chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc - Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc

Issue 490123003: Move bookmark_pref_names.* into bookmarks namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: REBASE Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc

diff --git a/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc b/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc

index 877c56faa35f122e812675cfdd78df32e870341f..a0a74beab42004e33bc0ada5b5366b3d47ecded4 100644

--- a/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc

+++ b/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc

@@ -24,7 +24,7 @@ class ManagedBookmarksPolicyHandlerTest

};

TEST_F(ManagedBookmarksPolicyHandlerTest, ApplyPolicySettings) {

- EXPECT_FALSE(store_->GetValue(prefs::kManagedBookmarks, NULL));

+ EXPECT_FALSE(store_->GetValue(bookmarks::prefs::kManagedBookmarks, NULL));

PolicyMap policy;

policy.Set(key::kManagedBookmarks,

@@ -66,7 +66,8 @@ TEST_F(ManagedBookmarksPolicyHandlerTest, ApplyPolicySettings) {

NULL);

UpdateProviderPolicy(policy);

const base::Value* pref_value = NULL;

- EXPECT_TRUE(store_->GetValue(prefs::kManagedBookmarks, &pref_value));

+ EXPECT_TRUE(

+ store_->GetValue(bookmarks::prefs::kManagedBookmarks, &pref_value));

ASSERT_TRUE(pref_value);

scoped_ptr<base::Value> expected(

@@ -117,7 +118,7 @@ TEST_F(ManagedBookmarksPolicyHandlerTest, WrongPolicyType) {

"]"),

NULL);

UpdateProviderPolicy(policy);

- EXPECT_FALSE(store_->GetValue(prefs::kManagedBookmarks, NULL));

+ EXPECT_FALSE(store_->GetValue(bookmarks::prefs::kManagedBookmarks, NULL));

}

TEST_F(ManagedBookmarksPolicyHandlerTest, UnknownKeys) {

@@ -136,7 +137,8 @@ TEST_F(ManagedBookmarksPolicyHandlerTest, UnknownKeys) {

NULL);

UpdateProviderPolicy(policy);

const base::Value* pref_value = NULL;

- EXPECT_TRUE(store_->GetValue(prefs::kManagedBookmarks, &pref_value));

+ EXPECT_TRUE(

+ store_->GetValue(bookmarks::prefs::kManagedBookmarks, &pref_value));

ASSERT_TRUE(pref_value);

scoped_ptr<base::Value> expected(

@@ -175,7 +177,8 @@ TEST_F(ManagedBookmarksPolicyHandlerTest, BadBookmark) {

NULL);

UpdateProviderPolicy(policy);

const base::Value* pref_value = NULL;

- EXPECT_TRUE(store_->GetValue(prefs::kManagedBookmarks, &pref_value));

+ EXPECT_TRUE(

+ store_->GetValue(bookmarks::prefs::kManagedBookmarks, &pref_value));

ASSERT_TRUE(pref_value);

scoped_ptr<base::Value> expected(

« no previous file with comments | « chrome/browser/policy/managed_bookmarks_policy_handler.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »