Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 418143004: Rename GrGpuObject to GrGpuResource (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@compact
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : Fix indents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -308 lines) Patch
M bench/GrResourceCacheBench.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M gyp/gpu.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 2 chunks +5 lines, -5 lines 0 comments Download
D include/gpu/GrGpuObject.h View 1 1 chunk +0 lines, -145 lines 0 comments Download
A + include/gpu/GrGpuResource.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
M include/gpu/GrSurface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrGeometryBuffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D src/gpu/GrGpuObject.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
A + src/gpu/GrGpuResource.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrPath.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathRange.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrResourceCache.h View 1 2 9 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrStencilBuffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 5 months ago (2014-07-25 14:37:03 UTC) #1
robertphillips
lgtm + 2 micro nits https://codereview.chromium.org/418143004/diff/20001/src/gpu/GrResourceCache.h File src/gpu/GrResourceCache.h (right): https://codereview.chromium.org/418143004/diff/20001/src/gpu/GrResourceCache.h#newcode146 src/gpu/GrResourceCache.h:146: GrResourceKey fKey; Fix indent ...
6 years, 5 months ago (2014-07-25 14:58:10 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-25 15:23:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/418143004/40001
6 years, 5 months ago (2014-07-25 15:24:20 UTC) #4
commit-bot: I haz the power
Change committed as 6d3fe022d68fd6dd32c0fab30e24fa5a4f048946
6 years, 5 months ago (2014-07-25 15:35:50 UTC) #5
bsalomon
6 years, 5 months ago (2014-07-25 16:16:15 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/418143004/diff/20001/src/gpu/GrResourceCache.h
File src/gpu/GrResourceCache.h (right):

https://codereview.chromium.org/418143004/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.h:146: GrResourceKey    fKey;
On 2014/07/25 14:58:09, robertphillips wrote:
> Fix indent ?

Done.

https://codereview.chromium.org/418143004/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.h:249: GrGpuResource* find(const GrResourceKey& key,
On 2014/07/25 14:58:09, robertphillips wrote:
> fix indent ?

Done.

Powered by Google App Engine
This is Rietveld 408576698