Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417193005: Add Value FromDict to Telemetry (Closed)

Created:
6 years, 4 months ago by eakuefner
Modified:
6 years, 4 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Value FromDict to Telemetry This CL adds a method FromDict for converting deserialized JSON dicts to values. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287716

Patch Set 1 #

Patch Set 2 : Core approach nailed down #

Patch Set 3 : More core logic + unittests for Value FromDict #

Patch Set 4 : Added logic for rest of types #

Patch Set 5 : Remove spurious todo #

Total comments: 6

Patch Set 6 : Subclass GetConstructor... -> FromDict + fixes #

Patch Set 7 : Address Nat's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -34 lines) Patch
M tools/telemetry/telemetry/value/__init__.py View 1 2 3 4 5 6 4 chunks +84 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/value/failure.py View 1 2 3 4 5 3 chunks +21 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/value/failure_unittest.py View 1 2 3 3 chunks +19 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 1 2 3 4 5 3 chunks +11 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram_unittest.py View 1 2 3 2 chunks +15 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values.py View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 1 2 3 2 chunks +25 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values.py View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values_unittest.py View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/scalar.py View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 1 2 3 1 chunk +27 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/skip.py View 1 2 3 4 5 2 chunks +14 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/skip_unittest.py View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/string.py View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/string_unittest.py View 1 2 3 1 chunk +14 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 2 3 4 5 6 3 chunks +89 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eakuefner
This patch is ready to be reviewed -- it adds the code for converting dicts ...
6 years, 4 months ago (2014-08-03 22:24:27 UTC) #1
eakuefner
Another pass, based on offline discussion with Nat.
6 years, 4 months ago (2014-08-04 21:44:30 UTC) #2
nduca
lgtm https://codereview.chromium.org/417193005/diff/80001/tools/telemetry/telemetry/value/__init__.py File tools/telemetry/telemetry/value/__init__.py (right): https://codereview.chromium.org/417193005/diff/80001/tools/telemetry/telemetry/value/__init__.py#newcode204 tools/telemetry/telemetry/value/__init__.py:204: """Recovers a value from a dict parsed from ...
6 years, 4 months ago (2014-08-04 21:46:12 UTC) #3
eakuefner
https://codereview.chromium.org/417193005/diff/80001/tools/telemetry/telemetry/value/__init__.py File tools/telemetry/telemetry/value/__init__.py (right): https://codereview.chromium.org/417193005/diff/80001/tools/telemetry/telemetry/value/__init__.py#newcode204 tools/telemetry/telemetry/value/__init__.py:204: """Recovers a value from a dict parsed from JSON ...
6 years, 4 months ago (2014-08-05 20:49:13 UTC) #4
eakuefner
The CQ bit was checked by eakuefner@chromium.org
6 years, 4 months ago (2014-08-05 20:49:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eakuefner@chromium.org/417193005/110001
6 years, 4 months ago (2014-08-05 20:54:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-06 01:43:44 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:49:06 UTC) #8
Message was sent while issue was closed. 
Change committed as 287716

Powered by Google App Engine
This is Rietveld 408576698